feat(compiler-cli): add param to set MissingTranslationStrategy on ngc #15987

ocombe · 2017-04-14T13:22:41Z

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature

What is the current behavior?
See issue #15808. We were unable to set the MissingTranslationStrategy for AOT (it only worked in JIT) because of a recent refactoring of the functionality.

What is the new behavior?
Added a new cli parameter missingTranslation for ngc that you can use to set the MissingTranslationStrategy. It takes the values error, warning or ignore. The internal APIs still use the enum MissingTranslationStrategy (the string parameters are converted to numbers, for consistency).

Does this PR introduce a breaking change?

[x] No

Other information:
I didn't add any test yet, not really sure how to test this?

vicb · 2017-04-19T22:18:53Z

packages/compiler-cli/src/codegen.ts

    }
    const {compiler: aotCompiler} = compiler.createAotCompiler(ngCompilerHost, {
      translations: transContent,
      i18nFormat: cliOptions.i18nFormat,
      locale: cliOptions.locale,
+      missingTranslation: missingTranslation,


nit: missingTranslation

vicb · 2017-04-19T22:29:19Z

packages/compiler-cli/src/codegen.ts

+        break;
+      case 'ignore':
+        missingTranslation = MissingTranslationStrategy.Ignore;
+        break;


default-> error unknown option

vicb

See inline comments + rebase needed

fixed

vicb · 2017-04-20T15:19:55Z

packages/compiler-cli/src/codegen.ts

+      }
+      transContent = readFileSync(cliOptions.i18nFile, 'utf8');
+    }
+    let missingTranslation;


init with the default MissingTranslationStrategy.Ignore

This commit adds a new parameter to ngc named `missingTranslation` to set the MissingTranslationStrategy for AoT, it takes the value `error`, `warning` or `ignore`. Fixes angular#15808

This adds the new parameter `missingTranslation` for AoT that was added in angular/angular#15987 and that let's you define the MissingTranslationStrategy

This adds the new parameter `missingTranslation` for AoT that was added in angular/angular/pull/15987 and that let's you define the MissingTranslationStrategy

This adds the new parameter `missingTranslation` for AoT that was added in angular/angular/pull/15987 and that lets you define the MissingTranslationStrategy

mhevery · 2017-04-24T16:54:10Z

This will go in in v4.0-beta.0 since v4.1 is no longer accepting features.

ocombe · 2017-04-24T16:59:09Z

You mean 4.2 beta 0? Not a problem, it's not a very important feature

mhevery · 2017-04-24T17:20:14Z

yes, that is what I meant.

This adds the new parameter `missingTranslation` for AoT that was added in angular/angular/pull/15987 and that lets you define the MissingTranslationStrategy

angular#15987) This commit adds a new parameter to ngc named `missingTranslation` to set the MissingTranslationStrategy for AoT, it takes the value `error`, `warning` or `ignore`. Fixes angular#15808 PR Close angular#15987

This adds the new parameter `missingTranslation` for AoT that was added in angular/angular/pull/15987 and that lets you define the MissingTranslationStrategy

angular#15987) This commit adds a new parameter to ngc named `missingTranslation` to set the MissingTranslationStrategy for AoT, it takes the value `error`, `warning` or `ignore`. Fixes angular#15808 PR Close angular#15987

This adds the new parameter `missingTranslation` for AoT that was added in angular/angular/pull/15987 and that lets you define the MissingTranslationStrategy

angular-automatic-lock-bot · 2019-09-11T18:22:45Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

ocombe added area: i18n Issues related to localization and internationalization action: discuss state: WIP labels Apr 14, 2017

ocombe requested a review from vicb April 14, 2017 13:22

googlebot added the cla: yes label Apr 14, 2017

ocombe force-pushed the fix-missing-translation-strategy-aot-15808 branch 5 times, most recently from df2aedd to f8eb24e Compare April 17, 2017 09:01

ocombe added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: discuss state: WIP labels Apr 19, 2017

vicb reviewed Apr 19, 2017

View reviewed changes

vicb previously requested changes Apr 19, 2017

View reviewed changes

ocombe force-pushed the fix-missing-translation-strategy-aot-15808 branch 4 times, most recently from a82feb0 to 8046c52 Compare April 20, 2017 09:48

ocombe removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 20, 2017

ocombe force-pushed the fix-missing-translation-strategy-aot-15808 branch from 8046c52 to 15d26ae Compare April 20, 2017 10:19

vicb reviewed Apr 20, 2017

View reviewed changes

feat(compiler-cli): add param to set MissingTranslationStrategy on ngc

409a107

This commit adds a new parameter to ngc named `missingTranslation` to set the MissingTranslationStrategy for AoT, it takes the value `error`, `warning` or `ignore`. Fixes angular#15808

ocombe force-pushed the fix-missing-translation-strategy-aot-15808 branch from 15d26ae to 409a107 Compare April 20, 2017 21:28

ocombe added the action: merge The PR is ready for merge by the caretaker label Apr 21, 2017

vicb approved these changes Apr 21, 2017

View reviewed changes

ocombe mentioned this pull request Apr 24, 2017

feat(@angular/cli): add AOT parameter missingTranslation angular/angular-cli#6053

Merged

mhevery closed this in 6e2abcd Apr 28, 2017

ocombe mentioned this pull request May 2, 2017

docs(aio): i18n guide updates for v4.0 - 4.2 #16469

Merged

3 tasks

ocombe deleted the fix-missing-translation-strategy-aot-15808 branch June 8, 2017 08:20

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(compiler-cli): add param to set MissingTranslationStrategy on ngc #15987

feat(compiler-cli): add param to set MissingTranslationStrategy on ngc #15987

Uh oh!

ocombe commented Apr 14, 2017 •

edited

Loading

Uh oh!

vicb Apr 19, 2017

Uh oh!

vicb Apr 19, 2017

Uh oh!

ocombe Apr 20, 2017

Uh oh!

vicb left a comment

Uh oh!

vicb Apr 20, 2017

Uh oh!

mhevery commented Apr 24, 2017

Uh oh!

ocombe commented Apr 24, 2017

Uh oh!

mhevery commented Apr 24, 2017

Uh oh!

angular-automatic-lock-bot bot commented Sep 11, 2019

Uh oh!

Uh oh!

feat(compiler-cli): add param to set MissingTranslationStrategy on ngc #15987

feat(compiler-cli): add param to set MissingTranslationStrategy on ngc #15987

Uh oh!

Conversation

ocombe commented Apr 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vicb Apr 19, 2017

Choose a reason for hiding this comment

Uh oh!

vicb Apr 19, 2017

Choose a reason for hiding this comment

Uh oh!

ocombe Apr 20, 2017

Choose a reason for hiding this comment

Uh oh!

vicb left a comment

Choose a reason for hiding this comment

Uh oh!

vicb Apr 20, 2017

Choose a reason for hiding this comment

Uh oh!

mhevery commented Apr 24, 2017

Uh oh!

ocombe commented Apr 24, 2017

Uh oh!

mhevery commented Apr 24, 2017

Uh oh!

angular-automatic-lock-bot bot commented Sep 11, 2019

Uh oh!

Uh oh!

ocombe commented Apr 14, 2017 •

edited

Loading