chore(material): add e2e smoke tests for a few more components. #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @juliemr |
| afterEach(testUtil.verifyNoBrowserErrors); | ||
|
|
||
| it('should set tiles into different positions', () => { | ||
| var tiles = element.all(by.css('md-grid-list#complex md-grid-tile')); |
There was a problem hiding this comment.
Element ID should be unique, why the md-grid-list selector?
There was a problem hiding this comment.
I thought it made it more clear what kind of element was being selected.
jelbourn
added a commit
that referenced
this pull request
May 18, 2015
kurthong
added a commit
to kurthong/angular
that referenced
this pull request
Apr 2, 2016
…n Node 5.6.0'(angular#1884) issue
kurthong
added a commit
to kurthong/angular
that referenced
this pull request
Apr 2, 2016
…n Node 5.6.0'(angular#1884) issue
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple smoke tests to prevent super obvious breaks.