fix(http): introduce named type for HttpParams options #19360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can preview 9e661cd at https://pr19360-9e661cd.ngbuilds.io/. |
|
I suppose it would be too difficult to add test coverage in this PR... |
alxhub
approved these changes
Sep 25, 2017
jelbourn
force-pushed
the
http-params-options
branch
from
9e661cd to
72276f9
Compare
|
Updated formatting and api gold |
jelbourn
added
action: review
|
You can preview 72276f9 at https://pr19360-72276f9.ngbuilds.io/. |
alxhub
approved these changes
Sep 25, 2017
jelbourn
added
action: merge
IgorMinar
suggested changes
Sep 25, 2017
packages/common/http/src/params.ts
Outdated
| @@ -73,6 +73,12 @@ interface Update { | |||
| op: 'a'|'d'|'s'; | |||
| } | |||
|
|
|||
| export interface HttpParamsOptions { | |||
There was a problem hiding this comment.
now that this is a public api, we need an api doc snippet for it.
@jelbourn can you please add a short one?
IgorMinar
added
action: cleanup
This is necessary to enable type-based optimizations with Closure. Without explicity making these options the same named type, Closure thinks they are different types and cannot disambiguate the `fromObject` property.
jelbourn
force-pushed
the
http-params-options
branch
from
72276f9 to
c78acf0
Compare
|
You can preview c78acf0 at https://pr19360-c78acf0.ngbuilds.io/. |
IgorMinar
approved these changes
Sep 26, 2017
IgorMinar
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to enable type-based optimizations with Closure.
Without explicity making these options the same named type, Closure
thinks they are different types and cannot disambiguate the
fromObjectproperty.
@alxhub @alexeagle let's discuss this together Monday morning