-
Notifications
You must be signed in to change notification settings - Fork 26.5k
feat(render): re-export render and export DirectiveResolver
#2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3154639
to
5d23e0b
Compare
b961154
to
3a4eada
Compare
DirectiveResolver
@tbosch can you review please? |
3a4eada
to
a7f886c
Compare
I updated the PR so it should be green and ready to go |
export * from './src/render/dom/shadow_dom/native_shadow_dom_strategy'; | ||
export * from './src/render/dom/shadow_dom/emulated_scoped_shadow_dom_strategy'; | ||
export * from './src/render/dom/shadow_dom/emulated_unscoped_shadow_dom_strategy'; | ||
export * from './src/core/compiler/dynamic_component_loader'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All exports from ./src/core/
should stay in angular2/core.ts
.
Looks good besides the comment above. |
And could you sqash into one commit? |
a7f886c
to
7499932
Compare
@tbosch I updated the PR with your suggestions. |
@gdi2290 Could you rebase ontop of master? |
7499932
to
8ba7fe5
Compare
@tbosch I pushed up the rebase |
Thanks Patrick! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
If you want to use native web components in your App then your bootstrap file would look like this.
rather than something like this
also complete a todo from @tbosch
https://github.com/angular/angular/blob/master/modules/angular2/core.js#L17
I'm re-exporting render in core unless you want me to remove it
it would also be nice to have
DirectiveResolver
exported inangular/core
so I added that here.