fix(test): improving unit tests results in IE11 and Firefox 38 #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -323,4 +323,7 @@ class BrowserDomAdapter extends GenericBrowserDomAdapter { | |||
| var baseUri = Uri.parse(uri); | |||
| return baseUri.path; | |||
| } | |||
| getUserAgent() { | |||
|
Are tests executed on Sauce for those browsers ? |
marclaval
force-pushed
the
utFirstBatch
branch
5 times, most recently
from
eb36650 to
eab4aa1
Compare
|
Comments integrated. About Sauce, it is not yet used, but it would be great to set it up once some browsers are green. |
|
LGTM after you add a missing comment to explain why we need one hack |
vicb
added
@lgtm
action: merge
… to "null" (IE11, Firefox)
…t not in DOM (IE11)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first batch of fixes to improve unit tests results in IE11 and Firefox 38.
With them, the numbers of failures is reduced as follows:
More fixes will follow, aiming to reach 0 in both.