-
Notifications
You must be signed in to change notification settings - Fork 26.6k
docs(forms): clarify note in reactive forms doc #21134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(forms): clarify note in reactive forms doc #21134
Conversation
@kara Would you review when you get a chance? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
please update the commit message. see #21110 (comment) |
b4cdad2
to
839505c
Compare
839505c
to
b908117
Compare
@kara I shouldn't need to approve this particular PR. Can you please send a PR that adds forms tutorial and guide md files to the existing forms group? thanks! |
@kara I shouldn't need to approve this particular PR. Can you please send a PR that adds forms tutorial and guide md files to the existing forms group? thanks! |
Haven't been able to get a green build here. Same reason as the other recent PR? |
@alexeagle I can rebase, but I see the tests are running. I can hold on pushing until we see if it fails. EDIT: It failed, so I've rebased and just pushed. |
b908117
to
4d50ee3
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #20058
What is the new behavior?
Change
formGroupName
to[formGroup]
.Does this PR introduce a breaking change?
Other information