Skip to content

Conversation

kapunahelewong
Copy link
Contributor

@kapunahelewong kapunahelewong commented Dec 21, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #20058

What is the new behavior?

Change formGroupName to [formGroup].

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kapunahelewong
Copy link
Contributor Author

@kara Would you review when you get a chance? Thank you!

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 22, 2017
@IgorMinar IgorMinar added comp: docs area: forms action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 22, 2017
@IgorMinar
Copy link
Contributor

please update the commit message. see #21110 (comment)

@kapunahelewong kapunahelewong force-pushed the wong-reactive-forms-fix branch from b4cdad2 to 839505c Compare January 2, 2018 20:47
@kapunahelewong kapunahelewong changed the title docs(aio): clarify note in reactive forms doc docs(forms): clarify note in reactive forms doc Jan 2, 2018
@kapunahelewong kapunahelewong force-pushed the wong-reactive-forms-fix branch from 839505c to b908117 Compare January 4, 2018 14:58
@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 9, 2018
@kara kara requested a review from IgorMinar January 9, 2018 23:22
@IgorMinar
Copy link
Contributor

@kara I shouldn't need to approve this particular PR. Can you please send a PR that adds forms tutorial and guide md files to the existing forms group? thanks!

@IgorMinar
Copy link
Contributor

@kara I shouldn't need to approve this particular PR. Can you please send a PR that adds forms tutorial and guide md files to the existing forms group? thanks!

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 10, 2018
@alexeagle
Copy link
Contributor

Haven't been able to get a green build here. Same reason as the other recent PR?

@kapunahelewong
Copy link
Contributor Author

kapunahelewong commented Jan 11, 2018

@alexeagle I can rebase, but I see the tests are running. I can hold on pushing until we see if it fails.

EDIT: It failed, so I've rebased and just pushed.

@kapunahelewong kapunahelewong force-pushed the wong-reactive-forms-fix branch from b908117 to 4d50ee3 Compare January 11, 2018 01:14
@alexeagle alexeagle added the target: patch This PR is targeted for the next patch release label Jan 11, 2018
alexeagle pushed a commit that referenced this pull request Jan 11, 2018
@alexeagle alexeagle closed this in 00300f6 Jan 11, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: forms cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants