fix(test): solve CSS discrepancies across browsers #2177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marclaval
force-pushed
the
utCSSCompare
branch
2 times, most recently
from
208884f to
300ae28
Compare
| expect(s(css, 'a')).toEqual(expected); | ||
| }); | ||
|
|
||
| it('should handle keyframes rules', () => { | ||
| var css = '@keyframes foo {0% {transform: translate(-50%) scaleX(0);}}'; | ||
| var passRe = RegExpWrapper.create( | ||
| '@keyframes foo {\\s*0% {\\s*transform: translate\\(-50%\\) scaleX\\(0\\);\\s*}}'); | ||
| '@keyframes foo {\\s*0% {\\s*transform:translate\\(-50%\\) scaleX\\(0\\);\\s*}\\s*}'); |
There was a problem hiding this comment.
do we still need the leading \\s* there ? (and then the RegExp)
There was a problem hiding this comment.
oops you actually have added some \\s*, discard my comment
marclaval
force-pushed
the
utCSSCompare
branch
2 times, most recently
from
9f4d2f7 to
29bc356
Compare
vicb
added
@lgtm
action: merge
|
lgtm with 1 comment |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 6 unit tests in IE11 and 2 in Firefox.
The
normalizeCSSfunction is a simple one that doesn't cover all possible cases, but only the ones found in the existing tests.