Skip to content

perf(ivy): improve Uglify configuration in hello world integration test #21985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

marclaval
Copy link
Contributor

This PRs implements suggestions from #21880
The bundle size is now 9.8k (vs ~8k with Closure)

@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer comp: ivy labels Feb 5, 2018
@marclaval marclaval requested a review from mhevery February 5, 2018 22:57
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 6, 2018
@trotyl
Copy link
Contributor

trotyl commented Feb 6, 2018

Since build-optimizer has provided its own rollup plugin, would it be better to use that official one instead of some 3rd-party not-well-maintained naive implementation?

Would require next build-optimizer, so could be done in separate PR.

@alxhub alxhub closed this in 7e51e52 Feb 6, 2018
@alexeagle
Copy link
Contributor

@trotyl has a good point - @marclaval do we even need this integration test anymore, since we're measuring bundles using "unit tests" in packages/core/test/bundling ?

@marclaval
Copy link
Contributor Author

@trotyl I've opened a PR to use the official plugin: #22121
@alexeagle From Igor's comment (#21940 (comment)), I understand we should keep it to see the trend

@alexeagle
Copy link
Contributor

I think we should get the trend from Daniel15/BuildSize#7 instead - need to evaluate that and we can tear down ours once we're satisfied with results and stability.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants