Skip to content

Conversation

lordrip
Copy link
Contributor

@lordrip lordrip commented Feb 20, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ X] No

Other information

Just a typo in http comments

@vicb vicb added action: merge The PR is ready for merge by the caretaker comp: http labels Feb 20, 2018
@ngbot
Copy link

ngbot bot commented Feb 20, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required label: "PR target: *"
    failure status "ci/circleci: lint" is failing
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb
Copy link
Contributor

vicb commented Feb 20, 2018

@lordrip Could you please fix you commit message: docs(http): fix a typo in code comment. Thanks.

@vicb vicb added the target: patch This PR is targeted for the next patch release label Feb 20, 2018
@lordrip lordrip changed the title Fixed typo in Http comments docs(http): fix a typo in code comment Feb 21, 2018
@lordrip lordrip force-pushed the typo-in-http-comments branch from e0c8bd9 to 2a9be37 Compare February 21, 2018 07:07
@lordrip
Copy link
Contributor Author

lordrip commented Feb 21, 2018

@vicb Yes, done, where can I find some guidellines for the ci/cicleci? just to make sure that I'm passing al the CI test (for example, to avoid this status "ci/circleci: lint" is failing), thanks a lot for all the people who makes Angular!

@vicb
Copy link
Contributor

vicb commented Feb 21, 2018

@lordrip thanks !

The easiest to pass the circle ci test is to format your code before submitting a PR by using
gulp format

For now formatting the code takes too long but we have a better system in the pipe that will format only the lines touched by your PR. Stay tuned.

vicb pushed a commit that referenced this pull request Feb 21, 2018
@vicb vicb closed this in 9e6268b Feb 21, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants