Skip to content

build: add support for the "merge-assistance" label in merge-pr #22414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: add support for the "merge-assistance" label in merge-pr #22414

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 23, 2018

fixes #22256

@vicb vicb added type: bug/fix area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 23, 2018
vicb
vicb commented Feb 23, 2018
View reviewed changes
scripts/github/merge-pr

if [[ "$PR_ACTION" != "PR action: merge" ]]; then
echo The PR is missing 'PR action: merge' label, found: $PR_ACTION
if [[ ! "$PR_ACTION" =~ "PR action: merge" ]]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the important change

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 23, 2018
@ngbot
Copy link

ngbot bot commented Feb 23, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required label: "PR target: *"
    failure status "ci/circleci: build" is failing
    failure status "ci/circleci: lint" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vicb vicb added the target: patch This PR is targeted for the next patch release label Feb 23, 2018
vicb added a commit that referenced this pull request Feb 23, 2018
@vicb
build: add support for the "merge-assistance" label in merge-pr (#22414)
4a08745 
fixes #22256

PR Close #22414
@vicb vicb closed this in 3a809cb Feb 23, 2018
@vicb vicb deleted the 0223-merge branch March 6, 2018 22:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@alexeagle alexeagle alexeagle approved these changes

@IgorMinar IgorMinar IgorMinar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GH sync script incorrectly report missing merge label
4 participants
@vicb @alexeagle @IgorMinar @googlebot