-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Events): allow a different local vs public name #2344
Conversation
return ListWrapper.map(db.eventEmitters, eventName => new EventEmitterAccessor( | ||
eventName, reflector.getter(eventName))); | ||
return ListWrapper.map(db.eventEmitters, eventConfig => { | ||
let localName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should call them fieldName and eventName?
fieldName is not really local: Angular attaches a listener to it, developers can interact with it when loading components dynamically.
Thanks for the review, I have updated the PR, PTAL. |
@@ -418,6 +418,18 @@ export function main() { | |||
expect(accessor.getter(new HasEventEmitter())).toEqual('emitter'); | |||
}); | |||
|
|||
it('should allow a different internal vs public name', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eventName and fieldName?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I'll update and merge
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
closes #2272