Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Events): allow a different local vs public name #2344

Closed
wants to merge 1 commit into from
Closed

feat(Events): allow a different local vs public name #2344

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jun 4, 2015

closes #2272

@vicb vicb added feature Issue that requests a new feature comp: core/di action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 4, 2015
vsavkin
vsavkin reviewed Jun 4, 2015
View reviewed changes
modules/angular2/src/core/compiler/element_injector.ts
return ListWrapper.map(db.eventEmitters, eventName => new EventEmitterAccessor(
eventName, reflector.getter(eventName)));
return ListWrapper.map(db.eventEmitters, eventConfig => {
let localName;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should call them fieldName and eventName?

fieldName is not really local: Angular attaches a listener to it, developers can interact with it when loading components dynamically.

@vsavkin vsavkin added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 4, 2015
@vsavkin vsavkin assigned vicb and unassigned vsavkin Jun 4, 2015
@vicb
Copy link
Contributor Author

vicb commented Jun 4, 2015

Thanks for the review, I have updated the PR, PTAL.

@vicb vicb removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 5, 2015
@vicb vicb assigned vsavkin and unassigned vicb Jun 5, 2015
vsavkin
vsavkin reviewed Jun 8, 2015
View reviewed changes
modules/angular2/test/core/compiler/element_injector_spec.ts
@@ -418,6 +418,18 @@ export function main() {
expect(accessor.getter(new HasEventEmitter())).toEqual('emitter');
});

it('should allow a different internal vs public name', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventName and fieldName?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I'll update and merge

@vsavkin vsavkin added pr_state: LGTM action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 8, 2015
@vsavkin vsavkin assigned vicb and unassigned vsavkin Jun 8, 2015
@vicb vicb closed this in 29c72ab Jun 8, 2015
@vicb vicb deleted the 0604-events branch June 8, 2015 17:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@vicb vicb

Labels
action: merge The PR is ready for merge by the caretaker cla: yes feature Issue that requests a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The events property should allow renaming similar to properties
3 participants
@vicb @vsavkin @googlebot