Skip to content

Conversation

jasonaden
Copy link
Contributor

This change adds to internal API hooks (undocumented API) for
before/afterPreactivation. The immediate need for this API is to
allow applications to build support for marshalling navigation between
a web worker and the main application.

Fixes #24202

@mary-poppins
Copy link

You can preview f2e8ae1 at https://pr24204-f2e8ae1.ngbuilds.io/.

@jasonaden
Copy link
Contributor Author

Presubmit

This change adds to internal API hooks (undocumented API) for
`before/afterPreactivation`. The immediate need for this API is to
allow applications to build support for marshalling navigation between
a web worker and the main application.

Fixes angular#24202
@jasonaden jasonaden force-pushed the feat_24202_router_hooks_extras branch from f2e8ae1 to 43debb9 Compare June 5, 2018 18:49
@mary-poppins
Copy link

You can preview 43debb9 at https://pr24204-43debb9.ngbuilds.io/.

@jasonaden
Copy link
Contributor Author

Presubmit

@jasonaden jasonaden added the action: merge The PR is ready for merge by the caretaker label Jun 5, 2018
@ngbot
Copy link

ngbot bot commented Jun 5, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required label: "PR target: *"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jasonaden jasonaden added the target: major This PR is targeted for the next major release label Jun 5, 2018
@vicb vicb closed this in 20c463e Jun 5, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extra parameter to the router hooks
5 participants