Skip to content

Conversation

benlesh
Copy link
Contributor

@benlesh benlesh commented Aug 13, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently there are issues in g3 due to this type mismatch (probably a typo) in the .bzl file.

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@benlesh benlesh requested a review from alexeagle August 13, 2018 20:01
@benlesh benlesh added the target: major This PR is targeted for the next major release label Aug 13, 2018
@mary-poppins
Copy link

You can preview 6fc4d90 at https://pr25467-6fc4d90.ngbuilds.io/.

@benlesh benlesh added the action: merge The PR is ready for merge by the caretaker label Aug 13, 2018
@benlesh
Copy link
Contributor Author

benlesh commented Aug 13, 2018

presubmit

@benlesh benlesh force-pushed the ng_module_bzl_fix branch from 6fc4d90 to f4dcec5 Compare August 14, 2018 00:27
@benlesh benlesh closed this in fb2c524 Aug 14, 2018
@mary-poppins
Copy link

You can preview f4dcec5 at https://pr25467-f4dcec5.ngbuilds.io/.

@benlesh benlesh deleted the ng_module_bzl_fix branch August 14, 2018 01:41
alexeagle pushed a commit to alexeagle/angular that referenced this pull request Sep 18, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants