Skip to content

Conversation

alexeagle
Copy link
Contributor

@alexeagle alexeagle commented Aug 28, 2018

fix for performance issue observed in g3

@mary-poppins
Copy link

You can preview fe02005 at https://pr25710-fe02005.ngbuilds.io/.

@alexeagle alexeagle requested a review from alxhub August 28, 2018 23:44
@alexeagle
Copy link
Contributor Author

I tried using the shouldCreateNewSourceFile argument to ts.CompilerHost#getSourceFile but it doesn't seem to do anything (and reading through the TS sources, I don't see why it would)

I tried using the existing program so we'd only use sourceFile's that are already parsed, but the program isn't available in this location it seems.

I tested manually that the g3 target which was broken before is now at the same speed as before the breakage.

@alexeagle alexeagle added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Aug 28, 2018
@ngbot
Copy link

ngbot bot commented Aug 28, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing
    failure missing required status "code-review/pullapprove"
    pending status "ci/circleci: test_ivy_aot" is pending
    pending status "ci/circleci: aio_preview" is pending
    pending status "ci/circleci: test" is pending
    pending status "ci/circleci: test_ivy_jit" is pending
    pending status "google3" is pending
    pending status "continuous-integration/travis-ci/pr" is pending
    pending status "ci/circleci: build-packages-dist" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mary-poppins
Copy link

You can preview f818c79 at https://pr25710-f818c79.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 1cbea39 at https://pr25710-1cbea39.ngbuilds.io/.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants