Skip to content

Conversation

alexeagle
Copy link
Contributor

Somehow 8a35290 introduced two copies of the rules_nodejs dependency

@alexeagle alexeagle requested a review from matsko August 29, 2018 19:12
@alexeagle alexeagle added PR target: patch-only action: merge The PR is ready for merge by the caretaker labels Aug 29, 2018
@ngbot
Copy link

ngbot bot commented Aug 29, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required status "code-review/pullapprove"
    pending status "ci/circleci: build-packages-dist" is pending
    pending status "ci/circleci: test_ivy_aot" is pending
    pending status "ci/circleci: test" is pending
    pending status "ci/circleci: test_ivy_jit" is pending
    pending status "ci/circleci: aio_preview" is pending
    pending status "ci/circleci: lint" is pending
    pending status "continuous-integration/travis-ci/pr" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

matsko pushed a commit that referenced this pull request Aug 29, 2018
@mhevery mhevery merged commit 88f7ddb into angular:6.1.x Aug 31, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants