Skip to content

docs-infra: Sort package and NgModule exports by id #26051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

docs-infra: Sort package and NgModule exports by id #26051

wants to merge 2 commits into from

Conversation

petebacondarwin
Copy link
Contributor

No description provided.

@petebacondarwin petebacondarwin added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours severity1: confusing target: patch This PR is targeted for the next patch release labels Sep 21, 2018
@petebacondarwin petebacondarwin added this to the Backlog milestone Sep 21, 2018
@ngbot ngbot bot modified the milestones: Backlog, needsTriage Sep 21, 2018
@petebacondarwin petebacondarwin force-pushed the aio-package-export-ordering branch from 14ceed6 to b797282 Compare September 21, 2018 08:35
@mary-poppins
Copy link

You can preview b797282 at https://pr26051-b797282.ngbuilds.io/.

@petebacondarwin petebacondarwin modified the milestones: needsTriage, Backlog Sep 21, 2018
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 21, 2018
@kara
Copy link
Contributor

kara commented Sep 21, 2018

@petebacondarwin Can you resolve the conflicts here?

@kara kara removed the action: merge The PR is ready for merge by the caretaker label Sep 21, 2018
@petebacondarwin petebacondarwin force-pushed the aio-package-export-ordering branch from b797282 to 86ac344 Compare September 21, 2018 20:02
@petebacondarwin
Copy link
Contributor Author

@kara - the PR is rebased.

@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Sep 21, 2018
@mary-poppins
Copy link

You can preview 86ac344 at https://pr26051-86ac344.ngbuilds.io/.

@kara kara closed this in 56c86c7 Sep 22, 2018
kara pushed a commit that referenced this pull request Sep 22, 2018
@petebacondarwin @kara
build(docs-infra): sort NgModule exports by id (#26051)
7f1cace 
PR Close #26051
kara pushed a commit that referenced this pull request Sep 22, 2018
@petebacondarwin @kara
build(docs-infra): sort package exports by id (#26051)
50cd655 
Closes #26046

PR Close #26051
kara pushed a commit that referenced this pull request Sep 22, 2018
@petebacondarwin @kara
build(docs-infra): sort NgModule exports by id (#26051)
37f3b92 
PR Close #26051
@petebacondarwin petebacondarwin deleted the aio-package-export-ordering branch September 22, 2018 18:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees

@kara kara

Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours freq1: low risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@petebacondarwin @mary-poppins @kara @gkalpak @googlebot