Skip to content

fix(transformer): Throw unimplemented errors in HtmlAdapter. #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jakemac53
Copy link
Contributor

closes #2624

@tbosch
Copy link
Contributor

tbosch commented Jun 18, 2015

This needs a little more investigation, as we actually should not call appendChild in this case at all...

@tbosch
Copy link
Contributor

tbosch commented Jun 18, 2015

Will look into it

@tbosch
Copy link
Contributor

tbosch commented Jun 19, 2015

Ok, double checked, this is correct. I got confused by some debugging that showed that we append children directly under a <template> tag, and not under its content document fragment. However, the html pub package does not have a content document fragment, so this is good.

Thannks @jakemac53 !

@jakemac53 jakemac53 deleted the html_adapter branch June 19, 2015 21:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dart HtmlAdapter should always throw unimplemented errors
5 participants