Skip to content

Conversation

null-reference
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

No behaviour change; minor wording change in code example.

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@brandonroberts brandonroberts self-assigned this Nov 1, 2018
@brandonroberts brandonroberts added type: bug/fix comp: docs effort1: hours area: router target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR labels Nov 1, 2018
@ngbot ngbot bot added this to the Backlog milestone Nov 1, 2018
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update git commit message to: docs: minor wording change in code example comment

@null-reference
Copy link
Contributor Author

Commit message updated.

@brandonroberts brandonroberts changed the title docs(examples): minor wording change in code example comment docs: minor wording change in code example comment Nov 8, 2018
@brandonroberts brandonroberts assigned IgorMinar and unassigned jasonaden Nov 9, 2018
@brandonroberts brandonroberts removed the request for review from jenniferfell January 14, 2019 16:16
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Jan 14, 2019
@brandonroberts brandonroberts changed the title docs: minor wording change in code example comment docs: minor wording change in observables guide code example comment Jan 14, 2019
@null-reference null-reference deleted the dignan-fix-branch branch January 17, 2019 13:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants