build: fix api guardian path for windows #26888
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
reviewed
Nov 1, 2018
alexeagle
reviewed
Nov 2, 2018
gkalpak
reviewed
Nov 3, 2018
At the moment, `path.posix.relative` will break paths in windows as it will return something like ``` Error: Source file "../C:/users/alag/_bazel_alag/3tbqurya/execroot/angular/bazel-out/x64_windows-fastbuild/bin/packages/core/core.d.ts" not found ```
In windows when using readFile `\n` are replaced with `\r\n` which causes issues when comparing golden files
|
CI is flaky |
alexeagle
approved these changes
Nov 13, 2018
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 13, 2018
At the moment, `path.posix.relative` will break paths in windows as it will return something like ``` Error: Source file "../C:/users/alag/_bazel_alag/3tbqurya/execroot/angular/bazel-out/x64_windows-fastbuild/bin/packages/core/core.d.ts" not found ``` PR Close #26888
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 13, 2018
In windows when using readFile `\n` are replaced with `\r\n` which causes issues when comparing golden files PR Close #26888
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 13, 2018
In windows when using readFile `\n` are replaced with `\r\n` which causes issues when comparing golden files PR Close #26888
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment,
path.posix.relativewill break paths in windows as it will return something likeRemove
\rfollowed by\nas in windows these causes golden files to be different.