-
Notifications
You must be signed in to change notification settings - Fork 25.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bazel): Builder should invoke local bazel/iblaze #28303
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
state: WIP
target: patch
This PR is targeted for the next patch release
area: bazel
Issues related to the published `@angular/bazel` build rules
labels
Jan 22, 2019
kyliau
force-pushed
the
builder
branch
4 times, most recently
from
January 22, 2019 23:30
7678561
to
a81805b
Compare
alfaproject
reviewed
Jan 23, 2019
kyliau
force-pushed
the
builder
branch
4 times, most recently
from
January 23, 2019 01:45
b5d74e7
to
aa79b57
Compare
jasonaden
added
area: bazel
Issues related to the published `@angular/bazel` build rules
and removed
area: bazel
Issues related to the published `@angular/bazel` build rules
labels
Jan 24, 2019
Builder for `@angular/bazel` schematics should not expect bazel/ibazel to be on the PATH. It should instead invoke the local executable installed by yarn/npm.
mgechev
approved these changes
Jan 25, 2019
kyliau
added
action: merge
The PR is ready for merge by the caretaker
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
labels
Jan 25, 2019
caretaker: only files in packages/bazel are modified in this PR. Approval from |
kyliau
removed
the
merge: caretaker note
Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
label
Jan 28, 2019
jasonaden
pushed a commit
that referenced
this pull request
Jan 28, 2019
Builder for `@angular/bazel` schematics should not expect bazel/ibazel to be on the PATH. It should instead invoke the local executable installed by yarn/npm. PR Close #28303
vetom
pushed a commit
to vetom/angular
that referenced
this pull request
Jan 31, 2019
Builder for `@angular/bazel` schematics should not expect bazel/ibazel to be on the PATH. It should instead invoke the local executable installed by yarn/npm. PR Close angular#28303
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: bazel
Issues related to the published `@angular/bazel` build rules
cla: yes
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builder for
@angular/bazel
schematics should not expect bazel/ibazelto be on the PATH. It should instead invoke the local executable
installed by yarn/npm.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information