Skip to content

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Jan 22, 2019

Builder for @angular/bazel schematics should not expect bazel/ibazel
to be on the PATH. It should instead invoke the local executable
installed by yarn/npm.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added state: WIP target: patch This PR is targeted for the next patch release area: bazel Issues related to the published `@angular/bazel` build rules labels Jan 22, 2019
@kyliau kyliau requested review from a team as code owners January 22, 2019 22:37
@kyliau kyliau force-pushed the builder branch 4 times, most recently from 7678561 to a81805b Compare January 22, 2019 23:30
@kyliau kyliau requested a review from a team as a code owner January 22, 2019 23:30
@kyliau kyliau force-pushed the builder branch 4 times, most recently from b5d74e7 to aa79b57 Compare January 23, 2019 01:45
@jasonaden jasonaden added area: bazel Issues related to the published `@angular/bazel` build rules and removed area: bazel Issues related to the published `@angular/bazel` build rules labels Jan 24, 2019
@ngbot ngbot bot added this to the needsTriage milestone Jan 24, 2019
Builder for `@angular/bazel` schematics should not expect bazel/ibazel
to be on the PATH. It should instead invoke the local executable
installed by yarn/npm.
@kyliau kyliau added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 25, 2019
@kyliau
Copy link
Contributor Author

kyliau commented Jan 25, 2019

caretaker: only files in packages/bazel are modified in this PR. Approval from tools-bazel members should be sufficient.

@kyliau kyliau removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 28, 2019
@jasonaden jasonaden closed this in 5dbc7d9 Jan 28, 2019
jasonaden pushed a commit that referenced this pull request Jan 28, 2019
Builder for `@angular/bazel` schematics should not expect bazel/ibazel
to be on the PATH. It should instead invoke the local executable
installed by yarn/npm.

PR Close #28303
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
Builder for `@angular/bazel` schematics should not expect bazel/ibazel
to be on the PATH. It should instead invoke the local executable
installed by yarn/npm.

PR Close angular#28303
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants