Skip to content

build: build and test examples using bazel #28402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

build: build and test examples using bazel #28402

wants to merge 2 commits into from

Conversation

devversion
Copy link
Member

@devversion devversion commented Jan 28, 2019 •
edited
Loading

Pushing the initial wip of building and testing the examples with Bazel. Now that we have decided on a consistent way of converting the examples to Bazel, this work can be continued now. WIP

@devversion devversion added state: WIP area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release labels Jan 28, 2019
@devversion devversion requested review from IgorMinar and a team as code owners January 28, 2019 17:28
@ngbot ngbot bot added this to the needsTriage milestone Jan 28, 2019
IgorMinar
IgorMinar reviewed Jan 28, 2019
View reviewed changes
@devversion devversion force-pushed the build/convert-examples-to-bazel branch 8 times, most recently from 610e331 to 8fd121c Compare January 28, 2019 20:49
@devversion
build: switch example e2e tests to bazel
1beabc1 
* No longer builds the example e2e tests using "tsc". The examples are now built with Bazel and can therefore be built with Ivy by using the `--define=compile=aot` switch.
* No longer runs the example e2e tests using the protractor CLI. example e2e tests are executed with the Bazel protractor rule and can therefore run incrementally.

NOTE: Unit tests found within the examples are still running within the legacy jobs.
@devversion
test: disable failing ivy example e2e tests
ce26a81
@devversion devversion force-pushed the build/convert-examples-to-bazel branch from 8fd121c to ce26a81 Compare January 28, 2019 21:01
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Jan 28, 2019
IgorMinar
IgorMinar approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 28, 2019
jasonaden pushed a commit that referenced this pull request Jan 29, 2019
@devversion @jasonaden
build: switch example e2e tests to bazel (#28402)
ef78e33 
* No longer builds the example e2e tests using "tsc". The examples are now built with Bazel and can therefore be built with Ivy by using the `--define=compile=aot` switch.
* No longer runs the example e2e tests using the protractor CLI. example e2e tests are executed with the Bazel protractor rule and can therefore run incrementally.

NOTE: Unit tests found within the examples are still running within the legacy jobs.

PR Close #28402
jasonaden pushed a commit that referenced this pull request Jan 29, 2019
@devversion @jasonaden
test: disable failing ivy example e2e tests (#28402)
351610c 
PR Close #28402
@jasonaden jasonaden closed this in 98e5af1 Jan 29, 2019
jasonaden pushed a commit that referenced this pull request Jan 29, 2019
@devversion @jasonaden
test: disable failing ivy example e2e tests (#28402)
2951329 
PR Close #28402
@devversion devversion deleted the build/convert-examples-to-bazel branch January 29, 2019 17:49
jasonaden added a commit to jasonaden/angular that referenced this pull request Jan 30, 2019
@jasonaden
Revert "test: disable failing ivy example e2e tests (angular#28402)"
6052e8d 
This reverts commit 351610c.
jasonaden added a commit to jasonaden/angular that referenced this pull request Jan 30, 2019
@jasonaden
Revert "build: switch example e2e tests to bazel (angular#28402)"
0a043bf 
This reverts commit ef78e33.
@jasonaden jasonaden mentioned this pull request Jan 30, 2019
Closed
jasonaden added a commit that referenced this pull request Jan 30, 2019
@jasonaden
Revert "test: disable failing ivy example e2e tests (#28402)" (#28438)
cbed485 
This reverts commit 351610c.

PR Close #28438
jasonaden added a commit that referenced this pull request Jan 30, 2019
@jasonaden
Revert "build: switch example e2e tests to bazel (#28402)" (#28438)
ea2a3f8 
This reverts commit ef78e33.

PR Close #28438
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@devversion @vetom
build: switch example e2e tests to bazel (angular#28402)
7051c59 
* No longer builds the example e2e tests using "tsc". The examples are now built with Bazel and can therefore be built with Ivy by using the `--define=compile=aot` switch.
* No longer runs the example e2e tests using the protractor CLI. example e2e tests are executed with the Bazel protractor rule and can therefore run incrementally.

NOTE: Unit tests found within the examples are still running within the legacy jobs.

PR Close angular#28402
vetom pushed a commit to vetom/angular that referenced this pull request Jan 31, 2019
@devversion @vetom
test: disable failing ivy example e2e tests (angular#28402)
ce5081f 
PR Close angular#28402
@devversion devversion mentioned this pull request Feb 14, 2019
Merged
devversion added a commit to devversion/angular that referenced this pull request Feb 20, 2019
@devversion
build: run example unit tests with bazel
e6dfe6a 
With angular#28402 we updated the `examples` package to be
built and tested with Bazel. This PR was only intended
for the e2e integration tests, and there still seem to be
a few unit tests that need to be migrated to Bazel until
we can remove the legacy local unit tests job.
IgorMinar pushed a commit that referenced this pull request Feb 21, 2019
@devversion @IgorMinar
build: run example unit tests with bazel (#28703)
abc3cbb 
With #28402 we updated the `examples` package to be
built and tested with Bazel. This PR was only intended
for the e2e integration tests, and there still seem to be
a few unit tests that need to be migrated to Bazel until
we can remove the legacy local unit tests job.

PR Close #28703
IgorMinar pushed a commit that referenced this pull request Feb 21, 2019
@devversion @IgorMinar
build: run example unit tests with bazel (#28703)
bcdd4b5 
With #28402 we updated the `examples` package to be
built and tested with Bazel. This PR was only intended
for the e2e integration tests, and there still seem to be
a few unit tests that need to be migrated to Bazel until
we can remove the legacy local unit tests job.

PR Close #28703
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@IgorMinar IgorMinar IgorMinar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @IgorMinar @googlebot