fix(ivy): remove nested placeholders with i18n #28595
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing that queries where unaffected by i18n translation that removed placeholders, I noticed that we actually forgot to remove nested placeholders because the logic to check for removed placeholders was wrong. We were using
previousOrParentTNode
to get the last created node, but it turns out that when you callelementEnd
,previousOrParentTNode
becomes the parent of the current node, and we would stop our check at the wrong index (index of the parent instead of the index of the last node).