Skip to content

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Feb 7, 2019

While testing that queries where unaffected by i18n translation that removed placeholders, I noticed that we actually forgot to remove nested placeholders because the logic to check for removed placeholders was wrong. We were using previousOrParentTNode to get the last created node, but it turns out that when you call elementEnd, previousOrParentTNode becomes the parent of the current node, and we would stop our check at the wrong index (index of the parent instead of the index of the last node).

@ocombe ocombe added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n Issues related to localization and internationalization target: major This PR is targeted for the next major release comp: ivy labels Feb 7, 2019
@ocombe ocombe requested a review from mhevery February 7, 2019 16:01
@ocombe ocombe requested review from a team as code owners February 7, 2019 16:01
@ngbot ngbot bot added this to the needsTriage milestone Feb 7, 2019
@ocombe ocombe force-pushed the test/ivy/tnode-detach branch from 371be92 to 7c2fa94 Compare February 7, 2019 16:15
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 7, 2019
@mhevery mhevery self-assigned this Feb 7, 2019
@mhevery
Copy link
Contributor

mhevery commented Feb 7, 2019

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: i18n Issues related to localization and internationalization cla: yes target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants