-
Notifications
You must be signed in to change notification settings - Fork 26.6k
docs: add globegitter to Angular collaborators #29142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We'll need to get a signed NDA from you so we can invite you to meetings. @manughub will send one. (It's so we can invite you to our subteam meetings) |
@manughub says the NDA is signed, thanks! |
Sent another reminder for NDA acceptance. Setting PR back to blocked. |
Ah sorry, I just saw this now, still taking me some time to get used to the way github ui shows me PRs I have been mentioned in. Will sort this out asap. |
You can preview 1ea9059 at https://pr29142-1ea9059.ngbuilds.io/. |
@alexeagle : Is there a reason this is master only, and not master & patch? |
I signed the NDA now. |
}, | ||
"globegitter": { | ||
"name": "Markus Padourek", | ||
"group": "Collaborator", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After #29553, this now needs to be changed to: groups: ["Collaborators"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
You can preview 502213b at https://pr29142-502213b.ngbuilds.io/. |
Also improve the presentation of the org chart
You can preview 1eadd2b at https://pr29142-1eadd2b.ngbuilds.io/. |
Also improve the presentation of the org chart PR Close #29142
Also improve the presentation of the org chart PR Close #29142
Also improve the presentation of the org chart PR Close angular#29142
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fyi @Globegitter