Skip to content

Conversation

alexeagle
Copy link
Contributor

@alexeagle alexeagle requested a review from a team as a code owner March 6, 2019 23:11
@ngbot ngbot bot added this to the needsTriage milestone Mar 7, 2019
@alexeagle
Copy link
Contributor Author

alexeagle commented Mar 7, 2019

We'll need to get a signed NDA from you so we can invite you to meetings. @manughub will send one.

(It's so we can invite you to our subteam meetings)

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed state: blocked labels Mar 11, 2019
@ngbot
Copy link

ngbot bot commented Mar 11, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure conflicts with base branch "master"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alexeagle
Copy link
Contributor Author

@manughub says the NDA is signed, thanks!

@manughub manughub added state: blocked and removed action: merge The PR is ready for merge by the caretaker labels Mar 11, 2019
@manughub
Copy link
Contributor

Sent another reminder for NDA acceptance. Setting PR back to blocked.

@Globegitter
Copy link

Ah sorry, I just saw this now, still taking me some time to get used to the way github ui shows me PRs I have been mentioned in. Will sort this out asap.

@jenniferfell jenniferfell changed the title docs(aio): add globegitter to Angular collaborators docs: add globegitter to Angular collaborators Mar 21, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Mar 21, 2019
@mary-poppins
Copy link

You can preview 1ea9059 at https://pr29142-1ea9059.ngbuilds.io/.

@jenniferfell
Copy link
Contributor

@alexeagle : Is there a reason this is master only, and not master & patch?

@Globegitter
Copy link

I signed the NDA now.

@gkalpak gkalpak added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Mar 29, 2019
},
"globegitter": {
"name": "Markus Padourek",
"group": "Collaborator",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #29553, this now needs to be changed to: groups: ["Collaborators"]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mary-poppins
Copy link

You can preview 502213b at https://pr29142-502213b.ngbuilds.io/.

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels Apr 8, 2019
@ngbot
Copy link

ngbot bot commented Apr 8, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test" is failing
    pending status "ci/angular: size" is pending
    pending status "ci/circleci: integration_test" is pending
    pending status "ci/circleci: material-unit-tests" is pending
    pending status "ci/circleci: test_aio" is pending
    pending status "ci/circleci: test_aio_local" is pending
    pending status "ci/circleci: test_aio_local_ivy" is pending
    pending status "ci/circleci: test_docs_examples" is pending
    pending status "ci/circleci: test_docs_examples_ivy" is pending
    pending status "ci/circleci: test_ivy_aot" is pending
    pending missing required status "ci/circleci: publish_snapshot"
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Also improve the presentation of the org chart
@alexeagle alexeagle requested a review from a team as a code owner April 10, 2019 23:06
@mary-poppins
Copy link

You can preview 1eadd2b at https://pr29142-1eadd2b.ngbuilds.io/.

@alexeagle alexeagle added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 10, 2019
@IgorMinar IgorMinar dismissed gkalpak’s stale review April 11, 2019 15:05

feedback addressed

@IgorMinar IgorMinar requested review from gkalpak and removed request for gkalpak April 11, 2019 15:05
@IgorMinar IgorMinar closed this in 77aff0b Apr 11, 2019
IgorMinar pushed a commit that referenced this pull request Apr 11, 2019
Also improve the presentation of the org chart

PR Close #29142
IgorMinar pushed a commit that referenced this pull request Apr 11, 2019
Also improve the presentation of the org chart

PR Close #29142
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
Also improve the presentation of the org chart

PR Close angular#29142
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours feature Issue that requests a new feature merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants