Skip to content

docs(changelog): cleanup 8.0.0 release notes #30740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

docs(changelog): cleanup 8.0.0 release notes #30740

wants to merge 4 commits into from

Conversation

JoostK
Copy link
Member

@JoostK JoostK commented May 29, 2019

docs(changelog): cleanup 8.0.0 release notes

The removal of @angular/http is now mentioned under breaking changes.

This removes several duplicate entries from the changelog and removes
long and incorrect "closes" links to sources on Github. Those links were
present in the commit message and are incorrectly seen as issue references.

Additionally, code references are wrapped in backticks for proper formatting

@JoostK
docs(changelog): cleanup 8.0.0 release notes
4ac2c6d 
The removal of @angular/http is now mentioned under breaking changes.

This removes several duplicate entries from the changelog and removes
long and incorrect "closes" links to sources on Github. Those links were
present in the commit message and are incorrectly seen as issue references.

Additionally, code references are wrapped in backticks for proper formatting.
@JoostK JoostK added comp: docs target: major This PR is targeted for the next major release labels May 29, 2019
@JoostK JoostK requested a review from IgorMinar May 29, 2019 21:10
@JoostK JoostK requested a review from a team as a code owner May 29, 2019 21:10
@ngbot ngbot bot added this to the needsTriage milestone May 29, 2019
@JoostK JoostK mentioned this pull request May 29, 2019
Closed
gkalpak
gkalpak approved these changes May 30, 2019
View reviewed changes
CHANGELOG.md Outdated

* TypeScript 3.1 and 3.2 are no longer supported.

Please update your TypeScript version to 3.3
Please update your TypeScript version to 3.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (in combination with the above sentence) is a little confusing. Is 3.3 supported or not? Do people on 3.3 need to upgrade?
I think we should explicitly mention that either 3.3 is not supported or mention that they can upgrade to 3.3 as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. We should state that 3.3 is not supported and 3.4 is the one that is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, v3.3 is now mentioned not to be supported

@gkalpak gkalpak added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 30, 2019
trotyl
trotyl reviewed May 30, 2019
View reviewed changes
CHANGELOG.md Outdated
@@ -71,57 +71,54 @@
* **bazel:** Exclude common/upgrade* in metadata.tsconfig.json ([#30133](https://github.com/angular/angular/issues/30133)) ([6711f22](https://github.com/angular/angular/commit/6711f22))
* **bazel:** update peerDep ranges ([#30155](https://github.com/angular/angular/issues/30155)) ([6067583](https://github.com/angular/angular/commit/6067583))
* **bazel:** make name param in ng add optional ([#30074](https://github.com/angular/angular/issues/30074)) ([0b5f480](https://github.com/angular/angular/commit/0b5f480))
* **bazel:** Make sure only single copy of `[@angular](https://github.com/angular)/bazel` is installed ([#30072](https://github.com/angular/angular/issues/30072)) ([2905bf5](https://github.com/angular/angular/commit/2905bf5))
* **bazel:** Make sure only single copy of [@angular](https://github.com/angular)/bazel is installed ([#30072](https://github.com/angular/angular/issues/30072)) ([2905bf5](https://github.com/angular/angular/commit/2905bf5))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all [@angular](https://github.com/angular) links are generated by mistake, linking NPM group to the GitHub organization doesn't make any sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. @JoostK could you please remove thel links? thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trotyl Good point, these have been fixed.

IgorMinar
IgorMinar approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning this up! Can you make the requested changes and then we can get this in? thanks again.

CHANGELOG.md Outdated

* TypeScript 3.1 and 3.2 are no longer supported.

Please update your TypeScript version to 3.3
Please update your TypeScript version to 3.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. We should state that 3.3 is not supported and 3.4 is the one that is.

CHANGELOG.md Outdated
@@ -71,57 +71,54 @@
* **bazel:** Exclude common/upgrade* in metadata.tsconfig.json ([#30133](https://github.com/angular/angular/issues/30133)) ([6711f22](https://github.com/angular/angular/commit/6711f22))
* **bazel:** update peerDep ranges ([#30155](https://github.com/angular/angular/issues/30155)) ([6067583](https://github.com/angular/angular/commit/6067583))
* **bazel:** make name param in ng add optional ([#30074](https://github.com/angular/angular/issues/30074)) ([0b5f480](https://github.com/angular/angular/commit/0b5f480))
* **bazel:** Make sure only single copy of `[@angular](https://github.com/angular)/bazel` is installed ([#30072](https://github.com/angular/angular/issues/30072)) ([2905bf5](https://github.com/angular/angular/commit/2905bf5))
* **bazel:** Make sure only single copy of [@angular](https://github.com/angular)/bazel is installed ([#30072](https://github.com/angular/angular/issues/30072)) ([2905bf5](https://github.com/angular/angular/commit/2905bf5))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. @JoostK could you please remove thel links? thanks

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label May 30, 2019
@ngbot
Copy link

ngbot bot commented May 30, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    failure status "ci-codefresh-bazel" is failing
    failure status "ci/circleci: test_ivy_aot" is failing
    pending forbidden labels detected: PR action: cleanup
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 30, 2019
@IgorMinar
Copy link
Contributor

merge-assistance: codefresh is still flaky.

@JoostK JoostK removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels May 30, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 30, 2019
@matsko matsko closed this in 7bf7244 May 30, 2019
@JoostK JoostK deleted the v8-release-notes branch May 30, 2019 17:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

+3 more reviewers

@trotyl trotyl trotyl left review comments

@IgorMinar IgorMinar IgorMinar approved these changes

@markgoho markgoho markgoho approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours freq3: high risk: medium target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
7 participants
@JoostK @IgorMinar @trotyl @gkalpak @markgoho @kapunahelewong @googlebot