-
Notifications
You must be signed in to change notification settings - Fork 26.6k
feat(forms): add ontouched on focusout event #31046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forms): add ontouched on focusout event #31046
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
CLA? |
Does it work now? |
@StefanNieuwenhuis are you by chance using a different email address than what you used to sign the CLA originally? When it's working, it should automatically change the label to the green |
Hi @kapunahelewong , I just checked it and, as far as I can see it's all synced.
Do I miss anything? |
The email you used for the commit is either empty or not associated with your GitHub account |
My e-mail was indeed different, so I've updated it. Thanks for pointing it out :) |
Hi @StefanNieuwenhuis, thanks for creating this PR and sorry that we didn't have a chance to review/respond sooner. The proposed change will be a breaking change for a large portion of applications (since new behavior would be invoked for a lot of input elements), so we would not be able to land it without a strong signal from the community that this change is mandatory to resolve a critical issue or there are major benefits that can justify the breaking change. I believe that in the mentioned use-case you should be able to achieve the necessary functionality by creating your custom value accessor (which can be based on default one with extra added functionality). Thank you. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
While using a custom form input element (i.e. a Custom Element), the validation engine won't fire while focussing out. This is because the onBlur event doesn't bubble.
Issue Number: N/A
What is the new behavior?
On focussing out, the onTouched() event handler will be triggered.
Does this PR introduce a breaking change?
Other information