Skip to content

Conversation

StefanNieuwenhuis
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

While using a custom form input element (i.e. a Custom Element), the validation engine won't fire while focussing out. This is because the onBlur event doesn't bubble.

Issue Number: N/A

What is the new behavior?

On focussing out, the onTouched() event handler will be triggered.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@StefanNieuwenhuis StefanNieuwenhuis requested a review from a team as a code owner June 14, 2019 09:14
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@StefanNieuwenhuis
Copy link
Author

CLA?

@StefanNieuwenhuis
Copy link
Author

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Does it work now?

@kapunahelewong
Copy link
Contributor

@StefanNieuwenhuis are you by chance using a different email address than what you used to sign the CLA originally? When it's working, it should automatically change the label to the green cla: yes.

@StefanNieuwenhuis
Copy link
Author

StefanNieuwenhuis commented Jun 14, 2019

Hi @kapunahelewong ,

I just checked it and, as far as I can see it's all synced.
I checked the following:

  • Gmail mail-address (my main account is the only active one)
  • Github mail-address (this was indeed a different one, but changed it 4 hours ago)
  • CLA Subscription (name, mail-address & GitHub account)

Do I miss anything?

@alfaproject
Copy link
Contributor

The email you used for the commit is either empty or not associated with your GitHub account

@StefanNieuwenhuis
Copy link
Author

The email you used for the commit is either empty or not associated with your GitHub account

My e-mail was indeed different, so I've updated it. Thanks for pointing it out :)

@ngbot ngbot bot added this to the needsTriage milestone Jun 19, 2019
@AndrewKushnir
Copy link
Contributor

Hi @StefanNieuwenhuis, thanks for creating this PR and sorry that we didn't have a chance to review/respond sooner.

The proposed change will be a breaking change for a large portion of applications (since new behavior would be invoked for a lot of input elements), so we would not be able to land it without a strong signal from the community that this change is mandatory to resolve a critical issue or there are major benefits that can justify the breaking change.

I believe that in the mentioned use-case you should be able to achieve the necessary functionality by creating your custom value accessor (which can be based on default one with extra added functionality).

Thank you.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants