Skip to content

Conversation

JiaLiPassion
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #31686
@webcomponents/shadydom polyfills will not work well with webapis-shadydom of zone.

What is the new behavior?

shadydom will work fine with polyfill in IE and Edge.

Does this PR introduce a breaking change?

  • Yes
  • No

@mhevery
Copy link
Contributor

mhevery commented Jul 22, 2019

Why no test?

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 22, 2019
@mhevery
Copy link
Contributor

mhevery commented Jul 22, 2019

@JiaLiPassion
Copy link
Contributor Author

@mhevery, I tested with a sample application locally, I will add unit tests with this one. thanks!

@JiaLiPassion JiaLiPassion requested a review from a team as a code owner July 23, 2019 05:46
@JiaLiPassion
Copy link
Contributor Author

@mhevery, I added test and make some refactor of the bazel karma rule to support normal browser test and shadydom test. please review, thanks.

mhevery pushed a commit that referenced this pull request Jul 24, 2019
@mhevery mhevery closed this in 35a025f Jul 24, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants