fix(ivy): i18n - turn on legacy message-id support by default #33053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
type: bug/fix
action: review
mhevery
approved these changes
Oct 9, 2019
petebacondarwin
added
action: merge
AndrewKushnir
added
the
action: presubmit
AndrewKushnir
approved these changes
Oct 9, 2019
petebacondarwin
force-pushed
the
i18n-legacy-message-id-default-on
branch
from
524da8c to
aa9c328
Compare
For v9 we want the migration to the new i18n to be as simple as possible. Previously the developer had to positively choose to use legacy messsage id support in the case that their translation files had not been migrated to the new format by setting the `legacyMessageIdFormat` option in tsconfig.json to the format of their translation files. Now this setting has been changed to `enableI18nLegacyMessageFormat` as is a boolean that defaults to `true`. The format is then read from the `i18nInFormat` option, which was previously used to trigger translations in the pre-ivy angular compiler.
petebacondarwin
force-pushed
the
i18n-legacy-message-id-default-on
branch
from
aa9c328 to
bec1b53
Compare
AndrewKushnir
removed
the
action: presubmit
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For v9 we want the migration to the new i18n to be as
simple as possible.
Previously the developer had to positively choose to use
legacy messsage id support in the case that their translation
files had not been migrated to the new format by setting the
legacyMessageIdFormatoption in tsconfig.json to the formatof their translation files.
Now this setting has been changed to
enableI18nLegacyMessageFormatas is a boolean that defaults to
true. The format is then read fromthe
i18nInFormatoption, which was previously used to trigger translationsin the pre-ivy angular compiler.