-
Notifications
You must be signed in to change notification settings - Fork 26.6k
docs: add deprecated-api-item class to deprecated items #34088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add deprecated-api-item class to deprecated items #34088
Conversation
You can preview 0914863 at https://pr34088-0914863.ngbuilds.io/. |
Thanks @ajitsinghkaler - did you check methods and other doc types too? |
Also I think you need a space between Fixes and #31455 in the commit message. |
Can I know which other methods and other doctypes I need to check |
Look through the API pages and think about what other things might be deprecated, such as methods. |
0914863
to
2ce91da
Compare
You can preview 2ce91da at https://pr34088-2ce91da.ngbuilds.io/. |
@petebacondarwin As I can see I 've checked only a 13 of 233 instances there are many instances where we are not striking through the deprecated elements. I'll try to check the rest of them later. If that is okay I'm attaching the images of the failed cases. Please have a look and tell me if we even need to strike through them. |
Please tell me what we need to do with them. |
Thanks for looking into this further. When I search the code-base I see that:
So the templates that deal with these missing items are where we need to focus our attention. If you want, we could mark this PR as merge, since it already improves the docs - and you could work on a 2nd PR for these other items. |
Okay, we can merge this and I'll start working on the others later. |
@petebacondarwin other items also work in the same way, I just have to play on the deprecated property that it and please go ahead and merge this. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes#31455
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Deprecated Items are not striked through
Issue Number: #31455
Deprecated Items are striked through
What is the new behavior?
Does this PR introduce a breaking change?
Other information