Skip to content

Conversation

ajitsinghkaler
Copy link
Contributor

Fixes#31455

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Deprecated Items are not striked through

Issue Number: #31455
Deprecated Items are striked through

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mary-poppins
Copy link

You can preview 0914863 at https://pr34088-0914863.ngbuilds.io/.

@petebacondarwin
Copy link
Contributor

Thanks @ajitsinghkaler - did you check methods and other doc types too?

@petebacondarwin
Copy link
Contributor

Also I think you need a space between Fixes and #31455 in the commit message.

@ngbot ngbot bot added this to the needsTriage milestone Nov 27, 2019
@ajitsinghkaler
Copy link
Contributor Author

Can I know which other methods and other doctypes I need to check

@petebacondarwin
Copy link
Contributor

Look through the API pages and think about what other things might be deprecated, such as methods.
It might be helpful to search the source code in https://github.com/angular/angular/tree/master/packages to find @deprecated tags and then check that those things are being displayed correctly in the site.

@ajitsinghkaler ajitsinghkaler force-pushed the remove-deprecated-items branch from 0914863 to 2ce91da Compare November 27, 2019 17:58
@petebacondarwin petebacondarwin added the target: patch This PR is targeted for the next patch release label Nov 27, 2019
@mary-poppins
Copy link

You can preview 2ce91da at https://pr34088-2ce91da.ngbuilds.io/.

@ajitsinghkaler
Copy link
Contributor Author

ajitsinghkaler commented Nov 27, 2019

@petebacondarwin As I can see I 've checked only a 13 of 233 instances there are many instances where we are not striking through the deprecated elements. I'll try to check the rest of them later. If that is okay I'm attaching the images of the failed cases. Please have a look and tell me if we even need to strike through them.

Desktop screenshot (17)
Desktop screenshot (16)
Desktop screenshot (15)
Desktop screenshot (14)
Desktop screenshot (13)
Desktop screenshot (11)

Desktop screenshot (12)

@ajitsinghkaler
Copy link
Contributor Author

Please tell me what we need to do with them.

@petebacondarwin
Copy link
Contributor

Thanks for looking into this further. When I search the code-base I see that:

So the templates that deal with these missing items are where we need to focus our attention.

If you want, we could mark this PR as merge, since it already improves the docs - and you could work on a 2nd PR for these other items.

@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label Nov 27, 2019
@ajitsinghkaler
Copy link
Contributor Author

Okay, we can merge this and I'll start working on the others later.

@ajitsinghkaler
Copy link
Contributor Author

ajitsinghkaler commented Nov 28, 2019

@petebacondarwin other items also work in the same way, I just have to play on the deprecated property that it and please go ahead and merge this.

@mhevery mhevery closed this in 72abde6 Dec 2, 2019
mhevery pushed a commit that referenced this pull request Dec 2, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 2, 2020
@ajitsinghkaler ajitsinghkaler deleted the remove-deprecated-items branch January 10, 2020 03:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants