Skip to content

fix(language-service): use host.error() instead of console.error() #34114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(language-service): use host.error() instead of console.error() #34114

wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Nov 28, 2019

host.error() would log to file, and makes error messages much easier
to inspect because entries are time-stamped.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

fix(language-service): use host.error() instead of console.error()
1ac96b3 
`host.error()` would log to file, and makes error messages much easier
to inspect because entries are time-stamped.
@kyliau kyliau added area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release labels Nov 28, 2019
@kyliau kyliau requested a review from ayazhafiz November 28, 2019 00:05
@kyliau kyliau requested a review from a team as a code owner November 28, 2019 00:05
@ngbot ngbot bot added this to the needsTriage milestone Nov 28, 2019
@ayazhafiz ayazhafiz added the action: merge The PR is ready for merge by the caretaker label Nov 28, 2019
@mhevery mhevery closed this in 99320e1 Dec 2, 2019
mhevery pushed a commit that referenced this pull request Dec 2, 2019
@mhevery
fix(language-service): use host.error() instead of console.error() (#…
7a7e999 
…34114)

`host.error()` would log to file, and makes error messages much easier
to inspect because entries are time-stamped.

PR Close #34114
@kyliau kyliau deleted the logImpossibleState branch December 17, 2019 20:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ayazhafiz ayazhafiz ayazhafiz approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
3 participants
@kyliau @ayazhafiz @googlebot