fix(ivy): reorder provider type checks to align with VE

[atscott]

The orderering matters because we don't currently throw if multiple
configurations are provided (i.e. provider has both useExisting and
useFactory). We should actually throw an error in this case, but to
avoid another breaking change in v9, this PR simply aligns the Ivy
behavior with ViewEngine.

current Ivy:

angular/packages/core/src/di/r3_injector.ts

Lines 485 to 488 in d0a04bf

	} else if (isExistingProvider(provider)) {
	factory = () => ɵɵinject(resolveForwardRef(provider.useExisting));
	} else if (isFactoryProvider(provider)) {
	factory = () => provider.useFactory(...injectArgs(provider.deps || []));

VE:

angular/packages/core/src/di/injector.ts

Lines 206 to 209 in d0a04bf

	} else if ((provider as FactoryProvider).useFactory) {
	fn = (provider as FactoryProvider).useFactory;
	} else if ((provider as ExistingProvider).useExisting) {
	// Just use IDENT

[kara]

Can you please add a test that verifies this behavior with a comment that links to the Jira?

Also - there's a typo in the commit message: orderering => ordering

[atscott]

VE presubmit
Ivy presubmit

[kara]

LGTM, thanks!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}