fix(ivy): append advance instructions before i18nExp
#34436
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
type: bug/fix
state: WIP
area: i18n
AndrewKushnir
force-pushed
the
FW-1775_advance_in_i18n
branch
from
94da2af to
1792f5a
Compare
AndrewKushnir
added
action: review
crisbeto
approved these changes
Jan 3, 2020
Prior to this commit, there were no `advance` instructions generated before `i18nExp` instructions and as a result, lifecycle hooks for components used inside i18n blocks were flushed too late. This commit adds the logic to generate `advance` instructions in front of `i18nExp` ones (similar to what we have in other places like interpolations, property bindings, etc), so that the necessary lifecycle hooks are flushed before expression value is captured.
AndrewKushnir
force-pushed
the
FW-1775_advance_in_i18n
branch
from
8a4f645 to
edbde2a
Compare
kara
added
action: merge
AndrewKushnir
removed
the
action: presubmit
alxhub
pushed a commit
that referenced
this pull request
Jan 7, 2020
Prior to this commit, there were no `advance` instructions generated before `i18nExp` instructions and as a result, lifecycle hooks for components used inside i18n blocks were flushed too late. This commit adds the logic to generate `advance` instructions in front of `i18nExp` ones (similar to what we have in other places like interpolations, property bindings, etc), so that the necessary lifecycle hooks are flushed before expression value is captured. PR Close #34436
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, there were no
advanceinstructions generated beforei18nExpinstructions and as a result, lifecycle hooks for components used inside i18n blocks were flushed too late. This commit adds the logic to generateadvanceinstructions in front ofi18nExpones (similar to what we have in other places like interpolations, property bindings, etc), so that the necessary lifecycle hooks are flushed before expression value is captured.This PR resolves FW-1775.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?