feat: performance improvement for eventListeners #34613
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Since now
DebugNode__PRE_R3__.triggerEventListener
will useeventListeners
method hereangular/packages/core/src/debug/debug_node.ts
Line 414 in f79110c
zone.js
, the current implementation is not performance efficient because it will loop all properties of the target and use regular expression to check the property name.This PR will do better.
eventName
parameter is not null (which is the most cases), we can directly get the event tasks from target.eventName
parameter is null, we will use the original logic.