Skip to content

fix(language-service): get the right 'ElementAst' in the nested HTML tag #35317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(language-service): get the right 'ElementAst' in the nested HTML tag #35317

wants to merge 1 commit into from

Conversation

ivanwonder
Copy link
Contributor

For example, <div><p string-model~{cursor}></p></div>, when provide the hover info for string-model, the path.head is root tag div. Use the parent of path.tail instead.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from kyliau February 11, 2020 02:33
@ivanwonder ivanwonder requested review from ayazhafiz and removed request for kyliau February 11, 2020 02:33
@pullapprove pullapprove bot requested a review from kyliau February 11, 2020 02:33
@ivanwonder ivanwonder force-pushed the attribute-in-nested-html-tag branch from 2d66a1b to 40e79ce Compare February 11, 2020 02:35
ayazhafiz
ayazhafiz approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@ayazhafiz ayazhafiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do path.first instead?

kyliau
kyliau reviewed Feb 11, 2020
View reviewed changes
@kyliau kyliau added area: language-service Issues related to Angular's VS Code language service target: patch This PR is targeted for the next patch release labels Feb 11, 2020
@ngbot ngbot bot added this to the needsTriage milestone Feb 11, 2020
@ivanwonder
Copy link
Contributor Author

Can we do path.first instead?

Yes, I will use it instead

@ivanwonder
fix(language-service): get the right 'ElementAst' in the nested HTML tag
8550303 
For example, '<div><p string-model~{cursor}></p></div>', when provide the hover info for 'string-model', the 'path.head' is root tag 'div'. Use the parent of 'path.tail' instead.
@ivanwonder ivanwonder force-pushed the attribute-in-nested-html-tag branch from 40e79ce to 8550303 Compare February 11, 2020 03:33
@ivanwonder ivanwonder requested a review from kyliau February 24, 2020 01:15
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Feb 25, 2020
@mhevery mhevery closed this in 8e354da Feb 25, 2020
mhevery pushed a commit that referenced this pull request Feb 25, 2020
@ivanwonder @mhevery
fix(language-service): get the right 'ElementAst' in the nested HTML …
7403ba1 
…tag (#35317)

For example, '<div><p string-model~{cursor}></p></div>', when provide the hover info for 'string-model', the 'path.head' is root tag 'div'. Use the parent of 'path.tail' instead.

PR Close #35317
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 27, 2020
@ivanwonder ivanwonder deleted the attribute-in-nested-html-tag branch April 1, 2020 11:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyliau kyliau kyliau approved these changes

@ayazhafiz ayazhafiz ayazhafiz approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
4 participants
@ivanwonder @kyliau @ayazhafiz @googlebot