feat(upgrade): Bootstrap with ng2 in ng1 #3539
Conversation
mhevery
added
action: cleanup
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
mhevery
force-pushed
the
upgrade
branch
2 times, most recently
from
10da120
to
e0d9c39
Compare
|
CLAs look good, thanks! |
mhevery
force-pushed
the
upgrade
branch
2 times, most recently
from
5523a4e
to
4be35ae
Compare
| */ | ||
| get changeDetectorRef(): ChangeDetectorRef { | ||
| if (this._changeDetectorRef === null) { | ||
| this._changeDetectorRef = new ChangeDetectorRef(this._view.changeDetector); |
There was a problem hiding this comment.
Every detector has a cached ref. Use _view.changeDetector.ref
There was a problem hiding this comment.
thanks for the tip. fixed
|
Maybe I am missing something, but it looks like Angular 1 and Angular 2 DI bindings are separate. Meaning that if I declare an angular 1 binding, it won't be injected into an angular 2 component and vice versa. I think we can make it work if we think it is important. |
|
It would be nice to add more integration tests. For instance, bootstrap's config and modules parameters are not tested. Also, as you pointed out the way scopes and detectors are wired up may not be correct. |
vsavkin
added
pr_state: LGTM
action: cleanup
|
Yes more of these tests are needed. Will add them as I work on the specific features. For example passing parameters, asserting order of things etc... |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is WIP, but wanted to get some feedback.