Skip to content

Conversation

JiaLiPassion
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The test case will random failed like this, https://circleci.com/gh/angular/angular/634629?utm_campaign=workflow-failed&utm_medium=email&utm_source=notification, the reason is the eventListeners are not cleared, and jasmine now run test cases in random orders, so some time, the eventListener of other test cases will be triggered.

What is the new behavior?

clear all event listeners when running cases.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from mhevery February 26, 2020 06:16
@JiaLiPassion JiaLiPassion added the area: zones Issues related to zone.js label Feb 26, 2020
@ngbot ngbot bot added this to the needsTriage milestone Feb 26, 2020
@JiaLiPassion JiaLiPassion added the target: patch This PR is targeted for the next patch release label Feb 28, 2020
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Mar 5, 2020
@matsko matsko added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 5, 2020
@matsko
Copy link
Contributor

matsko commented Mar 5, 2020

@JiaLiPassion this doesn't merge onto the patch branch properly. I changed it so that it only gets applied to the master branch. Could you create another PR that only applies it patch?

@matsko matsko closed this in 8ef29b6 Mar 5, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants