Skip to content

Conversation

EatingW
Copy link
Contributor

@EatingW EatingW commented Feb 28, 2020

This is needed to support angular/tsickle#1133
because it will add an extra require on tslib.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This is needed to support angular/tsickle#1133
because it will add an extra require on `tslib`.
@EatingW
Copy link
Contributor Author

EatingW commented Mar 2, 2020

Gentle ping. This is currently blocking an TS compiler update with the change in angular/tsickle#1133. Thanks!

@atscott atscott added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 3, 2020
@ngbot ngbot bot added this to the needsTriage milestone Mar 3, 2020
@alxhub alxhub added the target: major This PR is targeted for the next major release label Mar 4, 2020
@AndrewKushnir AndrewKushnir removed their request for review March 4, 2020 00:54
@alxhub alxhub added the action: merge The PR is ready for merge by the caretaker label Mar 4, 2020
@atscott atscott closed this in c296bfc Mar 4, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants