Skip to content

fix(core): Remove debugger statement when assert is thrown #35763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(core): Remove debugger statement when assert is thrown #35763

wants to merge 2 commits into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Feb 28, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Feb 28, 2020
@ngbot ngbot bot modified the milestone: needsTriage Feb 28, 2020
@pullapprove pullapprove bot requested a review from kara February 28, 2020 18:13
@mhevery mhevery force-pushed the issue-35470-option-b branch from a3cd327 to aa61b81 Compare February 28, 2020 18:17
@mhevery mhevery mentioned this pull request Feb 28, 2020
Closed
14 tasks
kara
kara approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Feb 28, 2020
@kara
Copy link
Contributor

kara commented Feb 28, 2020

merge-assistance: removing a debugger shouldn't require presubmit

atscott pushed a commit that referenced this pull request Feb 28, 2020
@mhevery @atscott
fix(core): Remove debugger statement (#35763)
e201a84 
Fix #35470

PR Close #35763
atscott pushed a commit that referenced this pull request Feb 28, 2020
@mhevery @atscott
fix(core): Remove debugger statement when assert is thrown (#35763)
d3ee052 
Fix #35470
Fix FW-1925

PR Close #35763
@atscott atscott closed this in 8f38eb7 Feb 28, 2020
atscott pushed a commit that referenced this pull request Feb 28, 2020
@mhevery @atscott
fix(core): Remove debugger statement when assert is thrown (#35763)
4003538 
Fix #35470
Fix FW-1925

PR Close #35763
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@kara kara kara approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
3 participants
@mhevery @kara @googlebot