fix(animations): allow computeStyle to work on elements created in Node #35810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsko
force-pushed
the
fix_gcs
branch
2 times, most recently
from
23ba7b2 to
8503e85
Compare
This patch is a follow-up patch to 35c9f0d. It changes the `computeStyle` function to handle situations where non string based values are returned from `window.getComputedStyle`. This situation usually ocurrs in Node-based test environments where the element or `window.getComputedStyle` is mocked out.
alxhub
approved these changes
Mar 3, 2020
atscott
pushed a commit
that referenced
this pull request
Mar 3, 2020
…de (#35810) This patch is a follow-up patch to 35c9f0d. It changes the `computeStyle` function to handle situations where non string based values are returned from `window.getComputedStyle`. This situation usually ocurrs in Node-based test environments where the element or `window.getComputedStyle` is mocked out. PR Close #35810
atscott
added a commit
to atscott/angular
that referenced
this pull request
Mar 4, 2020
…ed in Node (angular#35810)" This reverts commit 17cf04e; breaking internal tests.
atscott
added a commit
that referenced
this pull request
Mar 4, 2020
atscott
added a commit
that referenced
this pull request
Mar 4, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a follow-up patch to 35c9f0d.
It changes the
computeStylefunction to handle situations wherenon string based values are returned from
window.getComputedStyle.This situation usually ocurrs in Node-based test environments where
the element or
window.getComputedStyleis mocked out.