Skip to content

fix: <template> tag for browsers that do not support them #3636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Aug 14, 2015

No description provided.

@yjbanov yjbanov added this to the alpha-36 milestone Aug 14, 2015
@yjbanov yjbanov changed the title fix: <template> tag for browsers that do not suppor them fix: <template> tag for browsers that do not support them Aug 14, 2015
@vicb
Copy link
Contributor

vicb commented Aug 14, 2015

I guess templateAwareRoot() also needs to be modified ?

@mhevery
Copy link
Contributor

mhevery commented Aug 18, 2015

@vicb templateAwareRoot already has the check. this should be LGTM

@mhevery mhevery added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Aug 18, 2015
@mary-poppins
Copy link

Merging PR #3636 on behalf of @mhevery to branch presubmit-mhevery-pr-3636.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Aug 18, 2015
@vicb
Copy link
Contributor

vicb commented Aug 18, 2015

@mhevery I was not sure if is TemplateElement would work for those browser

@yjbanov yjbanov closed this in ddcfd46 Aug 18, 2015
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants