fix(language-service): disable update the @angular/core module

[ivanwonder]

After the user edits the file core.d.ts, the language-service will crash.

fix: angular/vscode-ng-language-service#713

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[kyliau]

Thanks for fixing this. I tried to debug this issue, but I was not 100% certain that this is the root cause of the problem. Regardless, since the compiler loads symbols from @angular/core at startup, I think it's reasonable that core.d.ts remains immutable throughout the lifetime of the language service.

[ivanwonder]

@kyliau

angular/packages/compiler/src/aot/static_reflector.ts

Line 69 in e6161ca

this.initializeConversionMap();

angular/packages/compiler/src/aot/static_reflector.ts

Line 159 in e6161ca

public annotations(type: StaticSymbol): any[] {

AFAIK, the param conversionMap is initialized here, and it's used to resolve the annotations. Correct me if I'm wrong.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}