-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compiler): add full directive metadata and validation logic #3880
Conversation
@@ -12,6 +13,27 @@ export class TypeMeta { | |||
} | |||
} | |||
|
|||
export class ChangeDetectionMeta { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not call this (and TemplateMeta
and TypeMeta
) ...Metadata for consistency ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @gkalpak - it would a longer, but a more explicit name.
Add a try/catch for expression parser and store the error in the |
Reviewed with @vsavkin in person |
With this, the new `TemplateParser` has feature/data parity with the `ProtoViewDto` of the `RenderCompiler`. Part of angular#3605
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.