Skip to content

feat(compiler): allow to create ChangeDetectors from parsed templates #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(compiler): allow to create ChangeDetectors from parsed templates #3950

wants to merge 1 commit into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Sep 1, 2015

Part of #3605

gkalpak
gkalpak reviewed Sep 2, 2015
View reviewed changes
modules/angular2/src/compiler/change_definition_factory.ts
@@ -0,0 +1,223 @@
import {Injectable} from 'angular2/di';

import {List, ListWrapper, MapWrapper} from 'angular2/src/core/facade/collection';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is List needed ?

@tbosch tbosch force-pushed the changedetection branch 2 times, most recently from 1e9d4da to af4865b Compare September 2, 2015 16:11
tbosch
tbosch reviewed Sep 2, 2015
View reviewed changes
modules/angular2/src/compiler/change_definition_factory.ts
}
var directiveMetadata = ast.directive;
var changeDetectionMeta = directiveMetadata.changeDetection;
this.directiveRecord = new DirectiveRecord({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

callbacks are missing:

            callAfterContentInit: directiveMetadata.callAfterContentInit,
            callAfterContentChecked: directiveMetadata.callAfterContentChecked,
            callAfterViewInit: directiveMetadata.callAfterViewInit,
            callAfterViewChecked: directiveMetadata.callAfterViewChecked,
            callOnChanges: directiveMetadata.callOnChanges,
            callDoCheck: directiveMetadata.callDoCheck,
            callOnInit: directiveMetadata.callOnInit,

@tbosch
Copy link
Contributor Author

tbosch commented Sep 2, 2015

Change Ast to use a context. For directives, do a manual loop and pass in the directive index.

@tbosch
Copy link
Contributor Author

tbosch commented Sep 2, 2015

Reviewed with @vsavkin in person.

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 2, 2015
@tbosch tbosch assigned tbosch and unassigned vsavkin Sep 2, 2015
@tbosch tbosch added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 2, 2015
@mary-poppins
Copy link

Merging PR #3950 on behalf of @tbosch to branch presubmit-tbosch-pr-3950.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Sep 2, 2015
@tbosch tbosch closed this in 2fea0c2 Sep 2, 2015
@tbosch tbosch deleted the changedetection branch September 3, 2015 20:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@tbosch tbosch

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tbosch @mary-poppins @gkalpak @vsavkin @googlebot