feat(compiler-cli): JIT compilation of directive declarations #40101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
added
target: minor
JoostK
force-pushed
the
linker/directive_jit
branch
from
a4eae7d to
58b0e29
Compare
JoostK
added
the
action: review
pullapprove
bot
added
area: compiler
JoostK
force-pushed
the
linker/directive_jit
branch
from
58b0e29 to
74c3d59
Compare
JoostK
commented
Dec 15, 2020
JoostK
force-pushed
the
linker/directive_jit
branch
2 times, most recently
from
6ce2b56 to
ff22db0
Compare
petebacondarwin
approved these changes
Dec 17, 2020
petebacondarwin
added
the
action: cleanup
The `ɵɵngDeclareDirective` calls are designed to be translated to fully AOT compiled code during a build transform, but in cases this is not done it is still possible to compile the declaration object in the browser using the JIT compiler. This commit adds a runtime implementation of `ɵɵngDeclareDirective` which invokes the JIT compiler using the declaration object, such that a compiled directive definition is made available to the Ivy runtime.
JoostK
force-pushed
the
linker/directive_jit
branch
from
20112e0 to
f55f899
Compare
jessicajaniuk
approved these changes
Dec 22, 2020
jessicajaniuk
removed
the
action: cleanup
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ɵɵngDeclareDirectivecalls are designed to be translated to fullyAOT compiled code during a build transform, but in cases this is not
done it is still possible to compile the declaration object in the
browser using the JIT compiler. This commit adds a runtime
implementation of
ɵɵngDeclareDirectivewhich invokes the JIT compilerusing the declaration object, such that a compiled directive definition
is made available to the Ivy runtime.