Skip to content

fix(browser): Moving to es6-shim broke most browsers #4219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(browser): Moving to es6-shim broke most browsers #4219

wants to merge 2 commits into from

Conversation

marclaval
Copy link
Contributor

Fixes #4216

For the 2 issues:

  1. Thanks to advices in Expected int32 as second argument in Firefox with Array.prototype.map paulmillr/es6-shim#347, loading es6-shim first solves the error.
  2. Added a workaround to use the internal string from es6-shim when Symbol.iteratoris not available.

@marclaval
Copy link
Contributor Author

Benchmarks are broken and need to be fixed, but at least unit tests are now running normally (with real errors to fix ...)
@rkirov Can you have a look please?

@marclaval
fix(browser): make Firefox to work with es6-shim
a0713cb 
es6-shim.js must be loaded first
@marclaval marclaval force-pushed the issue4216 branch 9 times, most recently from a623439 to b344ba7 Compare September 17, 2015 15:17
@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer comp: build/pipeline labels Sep 17, 2015
@marclaval marclaval mentioned this pull request Sep 17, 2015
Closed
rkirov
rkirov reviewed Sep 17, 2015
View reviewed changes
modules/angular2/src/core/facade/lang.ts
@@ -351,3 +351,24 @@ export function setValueOnPath(global: any, path: string, value: any) {
}
obj[parts.shift()] = value;
}

// TODO(mlaval): remove after https://github.com/paulmillr/es6-shim/issues/360
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like issue #360 is closed and Symbol.iterator won't be exposed. I don't like that this ties us up to es6-shim, which means angular2 bundle can't be used with core.js. Change the comment to specify that this workaround is es6-shim specific. I guess the todo is to add a similar work around for core.js.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core-js defines Symbol.iterator, so it shouldn't be a problem.

@rkirov rkirov added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 17, 2015
@marclaval marclaval closed this in 390aacd Sep 18, 2015
robwormald pushed a commit to robwormald/angular that referenced this pull request Sep 25, 2015
@marclaval @robwormald
fix(facade): workaround for lack of Symbol.iterator in es6-shim
5606f09 
Closes angular#4219
Fixes angular#4216
@marclaval marclaval deleted the issue4216 branch December 11, 2017 10:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rkirov rkirov

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving to es6-shim broke most browsers
3 participants
@marclaval @rkirov @googlebot