fix(core): allow readonly arrays in NgModule imports and exports #48106

pkozlowski-opensource · 2022-11-17T13:52:22Z

NgModule should support readonly arrays in @NgModule.imports and @NgModule.exports.

Partly fixes #48089 (#48091 is also needed)

pkozlowski-opensource · 2022-11-17T13:53:50Z

Note to a reviewer: I'm not sure if we can make this change in the patch release as technically it is widening the API surface. On the other hand it could be seen as a fix. On a fence here.

jessicajaniuk

LGTM

reviewed-for: fw-core, public-api

AndrewKushnir

Reviewed-for: public-api

ngbot · 2022-12-07T17:40:08Z

I see that you just added the action: merge label, but the following checks are still failing:
     status "google-internal-tests" is failing
     status "mergeability" is pending
     2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

ngbot · 2022-12-07T17:41:44Z

I see that you just added the action: merge label, but the following checks are still failing:
     status "google-internal-tests" is failing
     forbidden labels detected: action: cleanup
     4 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

alxhub · 2023-01-06T00:50:53Z

packages/core/src/metadata/ng_module.ts

@@ -136,7 +136,7 @@ export interface NgModule {
   * ```
   *
   */
-  imports?: Array<Type<any>|ModuleWithProviders<{}>|any[]>;
+  imports?: Array<Type<any>|ModuleWithProviders<{}>|ReadonlyArray<any>>;


Should this not be:

Suggested change

imports?: Array<Type<any>|ModuleWithProviders<{}>|ReadonlyArray<any>>;

imports?: Array<Type<any>|ModuleWithProviders<{}>|ReadonlyArray<Type<any>>>;

in which case I think we can just do:

Suggested change

imports?: Array<Type<any>|ModuleWithProviders<{}>|ReadonlyArray<any>>;

imports?: ReadonlyArray<Type<any>|ModuleWithProviders<{}>;

as all Arrays are implicitly ReadonlyArrays.

Can Type<any> represent an array of types? Previously, it was valid to import an array directly, like this:

const myArr = [/*...*/]; import: [myArr]

IMO keeping the type as-is can be more descriptive about what the import accepts.

hakimio · 2023-06-01T11:40:30Z

@pkozlowski-opensource are you planning to finish this PR anytime in near future?

tomastrajan · 2023-10-03T11:44:08Z

Any update on this?

hakimio · 2023-10-03T12:04:29Z

Based on the following rejections and @pkozlowski-opensource lack of response, it seems the PR will be just forgotten until it's closed due to its age.

distante · 2024-04-10T08:40:22Z

Following this since it is still a problem on production code.

NgModule should support readonly arrays in `@NgModule.imports` and `@NgModule.exports`. Fixes angular#48089

SanderElias · 2024-10-22T15:13:00Z

@pkozlowski-opensource @alxhub
Having this would be a huge boon for 3rth party Angular libraries.
Is there something we can to to help with this?

tomastrajan · 2025-04-30T10:30:36Z

@pkozlowski-opensource could you please provide a very short info if this was solved elsewhere or wont be solved or ? thank you!

angular-automatic-lock-bot · 2025-05-31T00:12:51Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

pkozlowski-opensource added area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release cross-cutting: standalone Issues related to the NgModule-less world labels Nov 17, 2022

ngbot bot modified the milestone: Backlog Nov 17, 2022

pkozlowski-opensource marked this pull request as ready for review November 17, 2022 14:35

pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 17, 2022

pullapprove bot requested review from alxhub, dylhunn and jessicajaniuk November 17, 2022 14:36

jessicajaniuk approved these changes Nov 17, 2022

View reviewed changes

pullapprove bot requested a review from AndrewKushnir November 17, 2022 19:22

AndrewKushnir approved these changes Nov 17, 2022

View reviewed changes

atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 7, 2022

pkozlowski-opensource requested review from AndrewKushnir and atscott December 7, 2022 17:40

atscott added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release action: merge The PR is ready for merge by the caretaker labels Dec 7, 2022

AndrewKushnir added action: merge The PR is ready for merge by the caretaker action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 7, 2022

atscott added action: presubmit The PR is in need of a google3 presubmit and removed action: merge The PR is ready for merge by the caretaker action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 7, 2022

pkozlowski-opensource force-pushed the standalone_ng_module_standalone_imports branch from c985860 to 22e317c Compare January 2, 2023 12:29

hakimio mentioned this pull request Jan 4, 2023

Exported array of standalone components cannot be imported #48089

Open

alxhub requested changes Jan 6, 2023

View reviewed changes

pkozlowski-opensource mentioned this pull request Apr 18, 2023

Angular Standalone library barrel files #49888

Closed

hakimio mentioned this pull request May 28, 2023

Deprecated/Removed Class-Based Guards and Resolvers #50234

Closed

pullapprove bot removed the request for review from atscott June 13, 2023 00:30

hakimio mentioned this pull request Jun 13, 2023

bug(all): directives are not standalone angular/components#26036

Closed

1 task

hakimio mentioned this pull request Nov 8, 2023

bug (docs): Bad recommendation to export standalone component groups as readonly array #52615

Closed

JeanMeche mentioned this pull request Apr 10, 2024

Type for @NgModule.imports is not compatible with recommended standalone group export #55278

Closed

pkozlowski-opensource force-pushed the standalone_ng_module_standalone_imports branch 3 times, most recently from 336e217 to 261ae4c Compare July 12, 2024 10:31

fix(core): allow readonly arrays in NgModule imports and exports

bf44b7d

NgModule should support readonly arrays in `@NgModule.imports` and `@NgModule.exports`. Fixes angular#48089

pkozlowski-opensource force-pushed the standalone_ng_module_standalone_imports branch from 261ae4c to bf44b7d Compare July 12, 2024 15:14

pkozlowski-opensource closed this Apr 30, 2025

angular-automatic-lock-bot bot locked and limited conversation to collaborators May 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(core): allow readonly arrays in NgModule imports and exports #48106

fix(core): allow readonly arrays in NgModule imports and exports #48106

Uh oh!

pkozlowski-opensource commented Nov 17, 2022

Uh oh!

pkozlowski-opensource commented Nov 17, 2022

Uh oh!

jessicajaniuk left a comment

Uh oh!

AndrewKushnir left a comment

Uh oh!

ngbot bot commented Dec 7, 2022

Uh oh!

ngbot bot commented Dec 7, 2022

Uh oh!

alxhub Jan 6, 2023

Uh oh!

csisy Aug 3, 2023 •

edited

Loading

Uh oh!

hakimio commented Jun 1, 2023

Uh oh!

tomastrajan commented Oct 3, 2023

Uh oh!

hakimio commented Oct 3, 2023

Uh oh!

distante commented Apr 10, 2024

Uh oh!

SanderElias commented Oct 22, 2024

Uh oh!

tomastrajan commented Apr 30, 2025

Uh oh!

angular-automatic-lock-bot bot commented May 31, 2025

Uh oh!

Uh oh!

	imports?: Array<Type<any>\|ModuleWithProviders<{}>\|ReadonlyArray<any>>;
	imports?: Array<Type<any>\|ModuleWithProviders<{}>\|ReadonlyArray<Type<any>>>;

	imports?: Array<Type<any>\|ModuleWithProviders<{}>\|ReadonlyArray<any>>;
	imports?: ReadonlyArray<Type<any>\|ModuleWithProviders<{}>;

fix(core): allow readonly arrays in NgModule imports and exports #48106

fix(core): allow readonly arrays in NgModule imports and exports #48106

Uh oh!

Conversation

pkozlowski-opensource commented Nov 17, 2022

Uh oh!

pkozlowski-opensource commented Nov 17, 2022

Uh oh!

jessicajaniuk left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

ngbot bot commented Dec 7, 2022

Uh oh!

ngbot bot commented Dec 7, 2022

Uh oh!

alxhub Jan 6, 2023

Choose a reason for hiding this comment

Uh oh!

csisy Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hakimio commented Jun 1, 2023

Uh oh!

tomastrajan commented Oct 3, 2023

Uh oh!

hakimio commented Oct 3, 2023

Uh oh!

distante commented Apr 10, 2024

Uh oh!

SanderElias commented Oct 22, 2024

Uh oh!

tomastrajan commented Apr 30, 2025

Uh oh!

angular-automatic-lock-bot bot commented May 31, 2025

Uh oh!

Uh oh!

csisy Aug 3, 2023 •

edited

Loading