-
Notifications
You must be signed in to change notification settings - Fork 25.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling precedence #48522
Comments
It does look like there is a page for this which is not linked from anywhere. |
Yes, even saw that. Under styling-precedence heading the content is irrelevant. This link has to be provided https://angular.io/guide/style-precedence. |
@kannanwisen Thanks for the feedback, but I'm not sure what you mean by irrelevant. Do you mean to say that the content below the Styling precedence heading is not helpful (which is what it appears to be to me)? Would linking to Style Precedence, or perhaps replacing in Class and style binding with the info from Style Precedence be more helpful? |
Yes, it is not helpful.
I feel the below link is better Replacing in Class and style binding with the info from Style Precedence be more helpful? |
This PR removes confusing "Styling Precedence" section from the "Class Binding" docs and adds more clarification on it in the following sections: "Binding to multiple styles" and "Binding to multiple CSS classes" which already have references to the "Style Precedence" docs, so there is no need to duplicate it. Fixes angular#48522.
@kannanwisen @alan-agius4 @bob-watson From my point of view - we have to keep the docs aligned with the DRY principle where possible, so I encourage avoiding docs duplication in two places: Class and style binding and Style Precedence. Even more, I suggest removing this section - ## Style Precendece - from Class and style binding because we already have references to Style Precedence docs in the following sections - ## Binding to multiple styles and ## Binding to multiple CSS classes. I added a bit more info to them to make it more transparent. It will also avoid extra code duplicates and confusion among developers. I prepared a PR for your review. Feel free to add any comments: |
FYI the guide has not been migrated to angular.dev at all, I opened this one to track that: #56085 |
Describe the problem that you experienced
I think, the explanation under Styling precedence Heading is inappropriate.
Enter the URL of the topic with the problem
https://angular.io/guide/class-binding#styling-precedence
Describe what you were looking for in the documentation
No response
Describe the actions that led you to experience the problem
No response
Describe what you want to experience that would fix the problem
No response
Add a screenshot if that helps illustrate the problem
No response
If this problem caused an exception or error, please paste it here
No response
If the problem is browser-specific, please specify the device, OS, browser, and version
No response
Provide any additional information here in as much as detail as you can
No response
The text was updated successfully, but these errors were encountered: