Skip to content

fix(default_value_accessor): support custom input elements that fire … #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Oct 23, 2015

…custom change events.

@tbosch
Copy link
Contributor Author

tbosch commented Oct 23, 2015

@vsavkin FYI, had to roll back the change to the selector of DefaultValueAccessor as it breaks G3, added an integration test that explains why.

Essentially they have a custom input component that fires a change event which does not contain a target property. Therefore, the host listener of the DefaultValueAccessor failed.

@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Oct 26, 2015
@mary-poppins
Copy link

Merging PR #4878 on behalf of @tbosch to branch presubmit-tbosch-pr-4878.

@mary-poppins mary-poppins removed the action: merge The PR is ready for merge by the caretaker label Oct 26, 2015
@tbosch tbosch closed this in 56a9b02 Oct 26, 2015
@tbosch tbosch deleted the form_fix branch October 26, 2015 20:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants