fix(http): ensure new cache state is returned on each request

[brandonroberts]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

The cache state is only used only the first server request. Restarting the server uses the cache on the first request.

Subsequent requests skip the cache because the CACHE_STATE object is mutated.

What is the new behavior?

A new cache state is returned on every server request.

Does this PR introduce a breaking change?

• Yes
• No

Other information

Angular v16.0.0-next.7 release with Universal installed and client hydration enabled
Reproduction: https://github.com/brandonroberts/angular-v16-universal-standalone

1. Clone the repo, install the dependencies
2. Run npm run dev:ssr
3. Visit the /todos route
4. Notice the API request is not made
5. Reload the page
6. Notice the API request is made on the client

[AndrewKushnir]

@brandonroberts thanks for reporting the issue and submitting a fix! We'll review it asap.

I'm wondering if you could help to put together a test that reproduces the problem, which would also help to ensure that there are no regressions in the future? This might be a good place for a test and it should contain the necessary helpers: https://github.com/angular/angular/blob/main/packages/platform-server/test/integration_spec.ts#L1097.

Thank you.

[brandonroberts]

Thanks @AndrewKushnir! Thanks for pointing me to the integration tests also. I wasn't sure where to start on that with it being an internal token.

[ngbot]

I see that you just added the action: merge label, but the following checks are still failing:
     status "ci/angular: size" is failing
     status "mergeability" is pending
     status "pullapprove" is pending
     1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

[AndrewKushnir]

@brandonroberts thanks again for the fix! We will proceed with the merge and we plan to expand the test coverage as a followup (in conjunction with other changes).

[AndrewKushnir]

This PR was merged into the repository by commit 0b3677e.

[brandonroberts]

Thanks @AndrewKushnir and @alan-agius4!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}