Skip to content

fix(styles): Escape \r characters in compiled text #5835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(styles): Escape \r characters in compiled text #5835

wants to merge 1 commit into from

Conversation

kegluneq
Copy link

Closes #5772

@vicb vicb added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Dec 11, 2015
@mary-poppins
Copy link

Merging PR #5835 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5835.

@vsavkin
Copy link
Contributor

vsavkin commented Dec 11, 2015

Can you fix Travis and reapply the merge label?

@vsavkin vsavkin removed the action: merge The PR is ready for merge by the caretaker label Dec 11, 2015
@kegluneq kegluneq added the action: merge The PR is ready for merge by the caretaker label Dec 11, 2015
@kegluneq kegluneq assigned vsavkin and unassigned tbosch Dec 11, 2015
@kegluneq
Copy link
Author

Done

@mary-poppins
Copy link

Merging PR #5835 on behalf of @vsavkin to branch presubmit-vsavkin-pr-5835.

@kegluneq kegluneq closed this Dec 11, 2015
@kegluneq kegluneq deleted the escape_styles branch December 11, 2015 20:10
kegluneq pushed a commit that referenced this pull request Dec 11, 2015
@kegluneq
fix(styles): Escape \r characters in compiled text
92ddc62 
Closes #5772

Closes #5835
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@vsavkin vsavkin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[windows][dart][alpha.51] Transformer error on @View styleUrls
6 participants
@kegluneq @mary-poppins @vsavkin @vicb @tbosch @googlebot