refactor(core): speed up view creation via codegen for view factories. #5993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
force-pushed
the
ultraperf
branch
9 times, most recently
from
0005d31 to
a53f014
Compare
|
|
||
| var _COMPILE_METADATA_FROM_JSON = { | ||
| 'Type': CompileTypeMetadata.fromJson, | ||
| 'Template': CompileTemplateMetadata.fromJson, |
There was a problem hiding this comment.
Remove Type and Template
|
Reviewed in person with @vsavkin |
tbosch
force-pushed
the
ultraperf
branch
10 times, most recently
from
2e42eb1 to
8a335f6
Compare
This was referenced Dec 29, 2015
Closed
The bundles will only be used if the flag `--useBundles` is passed to `gulp build.js`.
|
Also reviewed with @kegluneq for the transformer bits. |
tbosch
force-pushed
the
ultraperf
branch
3 times, most recently
from
f38258a to
54e176a
Compare
BREAKING CHANGE: - Platform pipes can only contain types and arrays of types, but no bindings any more. - When using transformers, platform pipes need to be specified explicitly in the pubspec.yaml via the new config option `platform_pipes`. - `Compiler.compileInHost` now returns a `HostViewFactoryRef` - Component view is not yet created when component constructor is called. -> use `onInit` lifecycle callback to access the view of a component - `ViewRef#setLocal` has been moved to new type `EmbeddedViewRef` - `internalView` is gone, use `EmbeddedViewRef.rootNodes` to access the root nodes of an embedded view - `renderer.setElementProperty`, `..setElementStyle`, `..setElementAttribute` now take a native element instead of an ElementRef - `Renderer` interface now operates on plain native nodes, instead of `RenderElementRef`s or `RenderViewRef`s
This was referenced Jan 8, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
but no bindings!
Compiler.compileInHostnow returns aHostViewFactoryRef-> use
onInitlifecycle callback to access the view of a componentViewRefis renamed toEmbeddedViewRefinternalViewis gone, useEmbeddedViewRef.rootNodesto accessthe root nodes of an embedded view
renderer.setElementProperty,..setElementStyle,..setElementAttributenowtake a native element instead of an ElementRef
Rendererinterface now operates on plain native nodes,instead of
RenderElementRefs orRenderViewRefs